Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade azure-sdk-for-go to v30.0.0 #88

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Upgrade azure-sdk-for-go to v30.0.0 #88

merged 1 commit into from
Jun 7, 2019

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jun 7, 2019

No description provided.

@katbyte katbyte added this to the v0.8.0 milestone Jun 7, 2019
@ghost ghost added the size/XXL label Jun 7, 2019
mbfrahry
mbfrahry approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katbyte katbyte merged commit 8a20bb7 into master Jun 7, 2019
@katbyte katbyte deleted the azure-go-sdk-30 branch June 7, 2019 21:28
katbyte added a commit that referenced this pull request Jun 7, 2019
@katbyte
Update CHANGELOG.md to include #88
4fc335d
@maxbog
Copy link

maxbog commented Jun 21, 2019

Hi,

According to this comment: hashicorp/terraform#18968 (comment) the verisons should be kept in sync with the https://github.com/hashicorp/go-azure-helpers and https://github.com/hashicorp/terraform repo. Is there a plan to upgrade the versions in the other two repos?

I created an issue in the go-azure-helpers repo, as the upgrade would fix a problem I have: hashicorp/go-azure-helpers#29

@ghost
Copy link

ghost commented Jul 8, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
dependencies size/XXL upstream-microsoft
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@katbyte @maxbog @mbfrahry