added azurerm_lb_rule data source for #8271

[alvintang]

Changes in this PR for #8271:

• Data source for azurerm_lb_rule
• Test for azurerm_lb_rule data source
• Documentation for azurerm_lb_rule

Fixes #8271

[manicminer]

@alvintang Thanks for this contribution. This is looking great, just a few minor comments and suggestions.

[manicminer]

Minor: I think we can shorten this to dataSourceArmLoadBalancerRuleRead (also singular name)

[manicminer]

We should use SchemaResourceGroupNameForDataSource() for data sources (doesn't set ForceNew)

Suggested change

	"resource_group_name": azure.SchemaResourceGroupName(),
	"resource_group_name": azure.SchemaResourceGroupNameForDataSource(),

[manicminer]

We can drop the extraneous "Error" prefix

Suggested change

	return fmt.Errorf("Error retrieving Load Balancer %s: %s", name, err)
	return fmt.Errorf("retrieving Load Balancer %s: %s", name, err)

[manicminer]

Same here

Suggested change

	return fmt.Errorf("Error setting `backend_address_pool_id`: %+v", err)
	return fmt.Errorf("setting `backend_address_pool_id`: %+v", err)

[manicminer]

and here

Suggested change

	return fmt.Errorf("Error setting `probe_id`: %+v", err)
	return fmt.Errorf("setting `probe_id`: %+v", err)

[manicminer]

Can we use TF 0.12 syntax?

Suggested change

	resource_group_name = "${azurerm_resource_group.test.name}"
	loadbalancer_id = "${azurerm_lb.test.id}"
	}
	resource "azurerm_lb_probe" "test" {
	name = "%s"
	resource_group_name = "${azurerm_resource_group.test.name}"
	loadbalancer_id = "${azurerm_lb.test.id}"
	protocol = "Tcp"
	port = 443
	}
	resource "azurerm_lb_rule" "test" {
	name = "%s"
	resource_group_name = "${azurerm_resource_group.test.name}"
	loadbalancer_id = "${azurerm_lb.test.id}"
	resource_group_name = azurerm_resource_group.test.name
	loadbalancer_id = azurerm_lb.test.id
	}
	resource "azurerm_lb_probe" "test" {
	name = "%s"
	resource_group_name = azurerm_resource_group.test.name
	loadbalancer_id = azurerm_lb.test.id
	protocol = "Tcp"
	port = 443
	}
	resource "azurerm_lb_rule" "test" {
	name = "%s"
	resource_group_name = azurerm_resource_group.test.name
	loadbalancer_id = azurerm_lb.test.id

[manicminer]

We don't need to specify this is a data source in the title

Suggested change

	page_title: "Azure Resource Manager: Data Source: azurerm_lb_rule"
	page_title: "Azure Resource Manager: azurerm_lb_rule"

[manicminer]

Suggested change

	* `resource_group_name` - (Required) The name of the Resource Group where the Load Balancer Rule exists. Changing this forces a new Load Balancer Rule to be created.
	* `resource_group_name` - (Required) The name of the Resource Group where the Load Balancer Rule exists.

[manicminer]

Suggested change

	* `disable_outbound_snat` - If snat is enabled for this Load Balancer Rule.
	* `disable_outbound_snat` - If outbound SNAT is enabled for this Load Balancer Rule.

[manicminer]

Suggested change

	* `enable_floating_ip` - If Floating IPs are enabled for this Load Balncer Rule
	* `enable_floating_ip` - If Floating IPs are enabled for this Load Balancer Rule

[alvintang]

Thanks for the review @manicminer. Latest commit addresses the comments.

[manicminer]

Thanks @alvintang, LGTM 👍

[ghost]

This has been released in version 2.27.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.27.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!