Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the prefix property of azurerm_cosmosdb_account since API's behavior has been changed #7588

Closed

Conversation

neil-yechenwei
Copy link
Contributor

fixes #5347

@@ -687,6 +685,7 @@ func resourceArmCosmosDbAccountApiUpsert(client *documentdb.DatabaseAccountsClie
stateConf := &resource.StateChangeConf{
Pending: []string{"Creating", "Updating", "Deleting", "Initializing"},
Target: []string{"Succeeded"},
Timeout: 180 * time.Minute,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be using the user specified timeout - rather than a hard-coded one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei - could update to the latest SDK before fixing this in case its changed again? either new PR or fix up #6253

This may also be the reason #6253 isn't working - so might make senseto upgrade the API and apply fixes there

@marc-sensenich
Copy link
Contributor

marc-sensenich commented Jul 6, 2020

@katbyte and @neil-yechenwei - I started #7597 for the Cosmos DB API update to the latest provided version by the Azure SDK for Go with the intentions of working on #6164 afterwards. I did a search after my PR and noticed this PR was also open after I started the work on mine

@neil-yechenwei
Copy link
Contributor Author

neil-yechenwei commented Jul 7, 2020

@katbyte & @marc-sensenich , I think I can update this PR once #6253/#7597 got merged.

@neil-yechenwei neil-yechenwei requested a review from katbyte July 7, 2020 05:02
@katbyte
Copy link
Collaborator

katbyte commented Jul 20, 2020

@neil-yechenwei - i believe this change was included in ##7597 so i am going to close it. let me know if that pr missedany thing and we should re-open it

@katbyte katbyte closed this Jul 20, 2020
@ghost
Copy link

ghost commented Aug 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure CosmosDB is recreated when geo_location.prefix is explicitly specified but is unchanged
4 participants