Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding sensitive kube_* values #7505

Closed
wants to merge 1 commit into from

Conversation

pwiens
Copy link

@pwiens pwiens commented Jun 25, 2020

This change will prevent leaking secrets during plan phase. This issue keeps getting punted between terraform core and this provider. This change will hide the entire block which seems safer to me than leaking secrets in deployment logs.

#7238
#5730
#5083
#4621

@ghost ghost added the size/XS label Jun 25, 2020
@tombuildsstuff
Copy link
Contributor

hi @pwiens

Thanks for opening this issue.

As mentioned in the other issues - unfortunately this needs to be fixed in the Terraform Plugin SDK, which is being tracked in this issue. Whilst we could look to make the entire block sensitive - some fields within that are not sensitive (e.g. hostname/username) - and so should be shown in the output.

Whilst I'd like to thank you for this contribution - I'm going to close this in favour of the upstream issue in the Terraform Plugin SDK (which has since been split out from Terraform Core, which is why this is linked in different places) which is tracking this - where once this is fixed this should then be available within the Azure Provider.

Thanks!

@ghost
Copy link

ghost commented Jul 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants