-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_kusto_database_principal_assignment
#7484
New Resource: azurerm_kusto_database_principal_assignment
#7484
Conversation
@katbyte This is currently WIP. I'll need to check whether everything works correctly. After all we need to deprecate the old "azurerm_database_principal" resource and give a hint to the new available resource within the docs. |
6010ea9
to
a7c9fa6
Compare
azurerm_kusto_database_principal_assignment
cc27375
to
fa0237f
Compare
@mbfrahry As it's the same structure as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jrauschenbusch
Many thanks for this new resource. It's looking really good, just a few minor changes below to address (some are items I'll be fixing up at a later date in the azurerm_kusto_cluster_principal_assignment
resource which I'm guessing you based this on?)
One additional item not in the comments below, could you add a requiresImport
acceptance test?
Thanks again!
azurerm/internal/services/kusto/kusto_database_principal_assignment_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/kusto/kusto_database_principal_assignment_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/kusto/kusto_database_principal_assignment_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/kusto/kusto_database_principal_assignment_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/kusto/kusto_database_principal_assignment_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/kusto/kusto_database_principal_assignment_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/kusto/kusto_database_principal_assignment_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/kusto/kusto_database_principal_assignment_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/kusto/kusto_database_principal_assignment_resource.go
Outdated
Show resolved
Hide resolved
website/docs/r/kusto_database_principal_assignment.html.markdown
Outdated
Show resolved
Hide resolved
b287e37
to
02f1723
Compare
@jackofallops I've fixed everything and added the Please review again. I had to do a |
vendor/github.com/hashicorp/go-azure-helpers/authentication/config.go
Outdated
Show resolved
Hide resolved
02f1723
to
0f6c53c
Compare
0f6c53c
to
14bac7a
Compare
This has been released in version 2.18.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.18.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
fixes #7383