app_service_environment resource - allow "Web, Publishing" for the internal_load_balancing_mode argument

[jbinko]

Currently the resource app_service_environment supports only three modes for InternalLoadBalancingMode argument:

0. None
1. Web
2. Publishing

But ASE supports one more ILB mode. It is combined value: "Web, Publishing"

0. None = public VIP only
1. Web = only ports 80/443 are mapped to ILB VIP
2. Publishing = only FTP ports are mapped to ILB VIP
3. Web, Publishing = both ports 80/443 and FTP ports are mapped to an ILB VIP.

This fix is accepting additional ILB mode number 3.

resource "azurerm_app_service_environment" "ase" {
name = var.aseName
resource_group_name = var.resourceGroupName
subnet_id = data.azurerm_subnet.aseSubnet.id
pricing_tier = "I2"
front_end_scale_factor = 10
internal_load_balancing_mode = "Web, Publishing"
}

[jackofallops]

Hi @jbinko
Thanks for this PR, just a a couple of comments below to address.

Additionally, could we have a test that covers this parameter being set too? (something like TestAccAzureRMAppServiceEnvironment_internalLoadBalancer)

Thanks again!

[jackofallops]

Is this documented / published somewhere? If not official, it's probably as well to leave this out for the time being.

[jbinko]

It is info from Microsoft ASE Program Manager - Christina - (my internal communication). No any official statement I'm aware of. Let me know what you prefer I'll change it accordingly.

[jackofallops]

Thanks - I think until the official information on this is published somewhere, we should avoid preempting it, plans and IT projects do have a way of changing unexpectedly!

[jbinko]

Hi @jbinko
Thanks for this PR, just a a couple of comments below to address.

Additionally, could we have a test that covers this parameter being set too? (something like TestAccAzureRMAppServiceEnvironment_internalLoadBalancer)

Thanks again!

OK I prepared some unit test. Please review. This is the result of unit test run:
make acctests SERVICE='web' TESTARGS='-run=TestAccAzureRMAppServiceEnvironment_internalLoadBalancer' TESTTIMEOUT='180m' ... TF_ACC=1 go test -v ./azurerm/internal/services/web/tests/ -run=TestAccAzureRMAppServiceEnvironment_internalLoadBalancer -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc" === RUN TestAccAzureRMAppServiceEnvironment_internalLoadBalancer === PAUSE TestAccAzureRMAppServiceEnvironment_internalLoadBalancer === CONT TestAccAzureRMAppServiceEnvironment_internalLoadBalancer --- PASS: TestAccAzureRMAppServiceEnvironment_internalLoadBalancer (5108.55s) PASS ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/web/tests 5108.694s

[jackofallops]

Thanks @jbinko
Just a couple of minor changes required. I'll get the tests run against this on CI so we're ready to merge when you've updated.

Thanks again!

[jackofallops]

Thanks - I think until the official information on this is published somewhere, we should avoid preempting it, plans and IT projects do have a way of changing unexpectedly!

[jackofallops]

Tests passing:

[ghost]

This has been released in version 2.16.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.16.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!