Issue #6059 - subscription rights for key_vault

[Jawvig]

This commit fixes issue #6509, in which some subscription level
rights are required in order to create a key_vault. This occurred
due to the provider always looking for a soft deleted key vault
prior to checking whether the feature
KeyVault.RecoverSoftDeletedKeyVaults was set to true. Thus event
setting the value to false did not stop it searching for the soft
deletions.

The rights it was requiring were to perform action
'Microsoft.KeyVault/locations/deletedVaults/read' over scope
'/subscriptions/xxxxxx'

[Jawvig]

Hold off on this. One of the acceptance tests is failing:

    TestAccAzureRMKeyVault_softDeleteRecoveryDisabled: testing.go:621: Step 3, no error received, but expected a match to:

        An existing soft-deleted Key Vault exists with the Name

I'll look into it further.

[Jawvig]

I see why the test is failing. I'm going to close this pull request and put some comments into #6059

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!