provider: fix more failing tests #5270
Conversation
…ercase resource groups
| config := testAccAzureRMApplicationInsightsAnalyticsItem_multiple(data) | ||
| r1 := acceptance.BuildTestData(t, "azurerm_application_insights_analytics_item", "test1") | ||
| r2 := acceptance.BuildTestData(t, "azurerm_application_insights_analytics_item", "test2") | ||
| r3 := acceptance.BuildTestData(t, "azurerm_application_insights_analytics_item", "test3") |
There was a problem hiding this comment.
this is fine - but we should probably update BuildTestData to handle being called multiple times within a single test case, at the moment we re-init the provider multiple times (each time this is called)
| @@ -260,7 +257,7 @@ resource "azurerm_monitor_diagnostic_setting" "test" { | |||
| } | |||
| } | |||
| } | |||
| `, data.RandomInteger, data.Locations.Primary, data.RandomInteger, data.RandomInteger, data.RandomInteger, data.RandomInteger) | |||
| `, data.RandomInteger, data.Locations.Primary, data.RandomInteger/10) | |||
There was a problem hiding this comment.
(as discussed offline) the /10 is ambiguous, and could be too long for the resource in question; it'd be better to handle adding the resource creation data via some other means (e.g. place the created date in a tag) and use RandomString here instead?
|
merging this for now since none of the above comments are immediately blocking |
|
Thanks, gonna try and replace the |
|
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
No description provided.