Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/healthcare_service: fixing the tests #5202

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Conversation

tombuildsstuff
Copy link
Contributor

Noticed the API behaviour had changed since we'd merged support for this so these tests are now failing whilst reviewing #5046

@tombuildsstuff tombuildsstuff added this to the v1.40.0 milestone Dec 17, 2019
@tombuildsstuff tombuildsstuff requested a review from a team December 17, 2019 22:06
@ghost ghost added the size/M label Dec 17, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

… computed

There's a default value set within Azure
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2019-12-18 at 08 15 14

@tombuildsstuff tombuildsstuff merged commit 286626f into master Dec 18, 2019
@tombuildsstuff tombuildsstuff deleted the b/healthcare-tests branch December 18, 2019 07:32
@ghost
Copy link

ghost commented Jan 8, 2020

This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.40.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants