Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to v30.0.0 Azure go sdk #3634

Merged
merged 3 commits into from
Jun 13, 2019

Conversation

r0bnet
Copy link
Contributor

@r0bnet r0bnet commented Jun 11, 2019

Need a feature from >=v30.0.0 for analysisservicesserver so i updated the version and fixed some incompatibilities.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pr @r0bnet! LGTM 👍

i hope you don't mind but i pushed some changed to resolve the merge conflict.

@r0bnet
Copy link
Contributor Author

r0bnet commented Jun 13, 2019

That's fine. Let's get this merged :)

@r0bnet r0bnet closed this Jun 13, 2019
@r0bnet r0bnet reopened this Jun 13, 2019
@r0bnet
Copy link
Contributor Author

r0bnet commented Jun 13, 2019

... accidentally closed this PR...

@katbyte katbyte added this to the v1.31.0 milestone Jun 13, 2019
@katbyte
Copy link
Collaborator

katbyte commented Jun 13, 2019

no bother, tests pass and merging now!

@katbyte katbyte merged commit abf8f47 into hashicorp:master Jun 13, 2019
@maxbog
Copy link
Contributor

maxbog commented Jun 21, 2019

Hi,

According to this comment: hashicorp/terraform#18968 (comment) the verisons should be kept in sync with the https://github.com/hashicorp/go-azure-helpers and https://github.com/hashicorp/terraform repo. Is there a plan to upgrade the versions in the other two repos?

I created an issue in the go-azure-helpers repo, as the upgrade would fix a problem I have: hashicorp/go-azure-helpers#29

@r0bnet r0bnet deleted the update-to-azure-go-sdk-v30.0.0 branch June 25, 2019 06:16
@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants