Fixing deadlock in subnet resources #3405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tombuildsstuff any comments or feedback here? |
|
@tombuildsstuff I made a haiku for you in case it helps get some feedback:
|
|
@tombuildsstuff I'm more than happy to go back and change this if it needs more work, just need some info on what the concern is, if there is one. Can we start a dialog here? |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assumption I'm making here is that the purpose of all these locks is to prevent the same resource being modified by multiple threads at the same time. None of these resources actually modify the route table, network security group, or vnet itself, so removing locks on those should be safe. I replaced the vnet locks with subnet locks which is modified by the route table association and nsg association.
If I'm wrong about why we have all these locks in here, please let me know. This is to fix #2489 and I've confirmed that it works on my local config that was previously triggering this problem.