Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/batch_account & r/batch_pool: temporarily treating the resource group name as case insensitive #3260

Merged
merged 1 commit into from
Apr 16, 2019
Merged

r/batch_account & r/batch_pool: temporarily treating the resource group name as case insensitive #3260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions azurerm/resource_arm_batch_account.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,12 @@ func resourceArmBatchAccount() *schema.Resource {
ForceNew: true,
ValidateFunc: validateAzureRMBatchAccountName,
},
"resource_group_name": resourceGroupNameSchema(),
"location": locationSchema(),

// TODO: make this case sensitive once this API bug has been fixed:
// https://github.com/Azure/azure-rest-api-specs/issues/5574
"resource_group_name": resourceGroupNameDiffSuppressSchema(),

"location": locationSchema(),
"storage_account_id": {
Type: schema.TypeString,
Optional: true,
Expand Down
6 changes: 5 additions & 1 deletion azurerm/resource_arm_batch_pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ func resourceArmBatchPool() *schema.Resource {
ForceNew: true,
ValidateFunc: azure.ValidateAzureRMBatchPoolName,
},
"resource_group_name": resourceGroupNameSchema(),

// TODO: make this case sensitive once this API bug has been fixed:
// https://github.com/Azure/azure-rest-api-specs/issues/5574
"resource_group_name": resourceGroupNameDiffSuppressSchema(),

"account_name": {
Type: schema.TypeString,
Required: true,
Expand Down
2 changes: 2 additions & 0 deletions website/docs/r/batch_account.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ The following arguments are supported:

* `resource_group_name` - (Required) The name of the resource group in which to create the Batch account. Changing this forces a new resource to be created.

~> **NOTE:** To work around [a bug in the Azure API](https://github.com/Azure/azure-rest-api-specs/issues/5574) this property is currently treated as case-insensitive. A future version of Terraform will require that the casing is correct.

* `location` - (Required) Specifies the supported Azure location where the resource exists. Changing this forces a new resource to be created.

* `pool_allocation_mode` - (Optional) Specifies the mode to use for pool allocation. Possible values are `BatchService` or `UserSubscription`. Defaults to `BatchService`.
Expand Down
2 changes: 2 additions & 0 deletions website/docs/r/batch_pool.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ The following arguments are supported:

* `resource_group_name` - (Required) The name of the resource group in which to create the Batch pool. Changing this forces a new resource to be created.

~> **NOTE:** To work around [a bug in the Azure API](https://github.com/Azure/azure-rest-api-specs/issues/5574) this property is currently treated as case-insensitive. A future version of Terraform will require that the casing is correct.

* `account_name` - (Required) Specifies the name of the Batch account in which the pool will be created. Changing this forces a new resource to be created.

* `node_agent_sku_id` - (Required) Specifies the Sku of the node agents that will be created in the Batch pool.
Expand Down