Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info for metric_name setting in autoscale_setting documentation #2760

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Jan 24, 2019

This PR fixes #2726 to address the documentation concern about metric_name for different types of resources.

@metacpp metacpp added this to the 1.22.0 milestone Jan 24, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional info @metacpp, LGTM 👍

@katbyte katbyte merged commit 70df19b into master Jan 25, 2019
@katbyte katbyte deleted the autoscacle_doc branch January 25, 2019 01:40
tombuildsstuff added a commit that referenced this pull request Jan 25, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_autoscale_setting fails on app_service_plan
2 participants