Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_lb_backend_address_pool_address - when using this resource, values are no longer reset on azurerm_lb_backend_address_pool #26264

Merged
merged 2 commits into from
Jun 11, 2024
Merged

azurerm_lb_backend_address_pool_address - when using this resource, values are no longer reset on azurerm_lb_backend_address_pool #26264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72e3d5d
fix the property values other than backend addresse being cleared issue
sinbai Jun 7, 2024
3e3426e
update code
sinbai Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions internal/services/loadbalancer/backend_address_pool_address_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,10 @@ func (r BackendAddressPoolAddressResource) Create() sdk.ResourceFunc {
})
}

backendAddressPool := loadbalancers.BackendAddressPool{
Properties: &loadbalancers.BackendAddressPoolPropertiesFormat{
LoadBalancerBackendAddresses: &addresses,
},
}
pool.Model.Properties.LoadBalancerBackendAddresses = &addresses

metadata.Logger.Infof("adding %s..", id)
err = lbClient.LoadBalancerBackendAddressPoolsCreateOrUpdateThenPoll(ctx, *poolId, backendAddressPool)
err = lbClient.LoadBalancerBackendAddressPoolsCreateOrUpdateThenPoll(ctx, *poolId, *pool.Model)
if err != nil {
return fmt.Errorf("updating %s: %+v", id, err)
}
Expand Down Expand Up @@ -478,11 +475,7 @@ func (r BackendAddressPoolAddressResource) Update() sdk.ResourceFunc {
}
}

backendAddressPool := loadbalancers.BackendAddressPool{
Properties: &loadbalancers.BackendAddressPoolPropertiesFormat{
LoadBalancerBackendAddresses: &addresses,
},
}
pool.Model.Properties.LoadBalancerBackendAddresses = &addresses

timeout, _ := ctx.Deadline()
lbStatus := &pluginsdk.StateChangeConf{
Expand All @@ -499,7 +492,7 @@ func (r BackendAddressPoolAddressResource) Update() sdk.ResourceFunc {
return fmt.Errorf("waiting for parent resource loadbalancer status to be ready error: %+v", err)
}

err = lbClient.LoadBalancerBackendAddressPoolsCreateOrUpdateThenPoll(ctx, poolId, backendAddressPool)
err = lbClient.LoadBalancerBackendAddressPoolsCreateOrUpdateThenPoll(ctx, poolId, *pool.Model)
if err != nil {
return fmt.Errorf("updating %s: %+v", *id, err)
}
Expand Down
9 changes: 3 additions & 6 deletions internal/services/loadbalancer/backend_address_pool_address_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,12 +190,9 @@ func (BackendAddressPoolAddressResourceTests) Destroy(ctx context.Context, clien
}
}

backendAddressPool := loadbalancers.BackendAddressPool{
Properties: &loadbalancers.BackendAddressPoolPropertiesFormat{
LoadBalancerBackendAddresses: &newAddresses,
},
}
err = client.LoadBalancers.LoadBalancersClient.LoadBalancerBackendAddressPoolsCreateOrUpdateThenPoll(ctx, poolId, backendAddressPool)
pool.Model.Properties.LoadBalancerBackendAddresses = &newAddresses

err = client.LoadBalancers.LoadBalancersClient.LoadBalancerBackendAddressPoolsCreateOrUpdateThenPoll(ctx, poolId, *pool.Model)
if err != nil {
return nil, fmt.Errorf("updating %s: %+v", *id, err)
}
Expand Down
Loading