azurerm_system_center_virtual_machine_manager_server - add StateRefreshFunc for checking the sync status

[neil-yechenwei]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Though azurerm_system_center_virtual_machine_manager_server is created successfully. But we can't use azurerm_system_center_virtual_machine_manager_inventory_items to get the list of Inventory Items immediately since Inventory Items are still in sync. Service team confirmed that it's expected since the backend operator creates CRD (Custom Resource Definitions) for all the existing resource from onPrem and create InventoryItem resources which takes some time after PUT VMM Server operation. So it's not a bug but it takes some while to populate the inventory item resource. Service team also confirmed that the sync would definitely be completed within ten minutes. So we just need to set a timeout of 10 minutes and check the inventory quantity continuously every minute for 10 times. If the quantity doesn't change, then we consider the sync to be complete.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

--- PASS: TestAccSystemCenterVirtualMachineManagerServerSequential/scvmmServer/basic (357.61s)
--- PASS: TestAccSystemCenterVirtualMachineManagerServerSequential/scvmmServer/requiresImport (295.43s)
--- PASS: TestAccSystemCenterVirtualMachineManagerServerSequential/scvmmServer/complete (352.76s)
--- PASS: TestAccSystemCenterVirtualMachineManagerServerSequential/scvmmServer/update (424.02s)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_system_center_virtual_machine_manager_server - add StateRefreshFunc for checking the sync status

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[tombuildsstuff]

Related: #25429 (comment)

[catriona-m]

Related: #25429 (comment)

Hi @neil-yechenwei - just checking in to see if there any updates about the concerns referenced in the above comment? Thanks

[neil-yechenwei]

@catriona-m , service team has replied that thread.

[katbyte]

LGTM 🔍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.