azurerm_monitor_private_link_scope - api 2021-07-01-preview - ingestion and query mode access added

[KiPIDesTAN]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Updated Azure Monitor Private Link Scope to the latest API, 2021-07-01-preview, to support ingestion mode access and query mode access. Fixes #19370 and fixes #10059.

This item adds ingestion_access_mode and query_access_mode items as required items to the azurerm_monitor_private_link_scope resource.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

• azurerm_monitor_private_link_scope - support for the ingestion_access_mode and query_access_mode property [Attribute missing from azure monitor private link scope resource  #19370]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #19370
Fixes #10059

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[katbyte]

Thanks for the pr @KiPIDesTAN - overall looks good but i think this is a breaking change for users with these properties being optiona;?

[stephybun]

Apologies @KiPIDesTAN it appears I was overzealous when doing some housekeeping in our SDK and removed the 2021-07-01-preview version since it wasn't in use in the provider at the time.

Leaving this comment here so maintainers know not to merge until hashicorp/pandora#4134 has been merged and reincorporated in the provider.

[KiPIDesTAN]

@katbyte , any chance you can look at this again? The pandora item mentioned above has been merged back into main.

[stephybun]

@KiPIDesTAN could you rebase your PR on main and resolve the conflicts? I can look through this once that's done.

[KiPIDesTAN]

@stephybun , thanks. Just finished the rebase and should be good.

[stephybun]

Thanks @KiPIDesTAN. Could you take a look at the suggestions and questions left in-line? Once that's done this should be good to go.

[stephybun]

Thanks @KiPIDesTAN. Tests look good LGTM 🚀

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.