azurerm_linux_function_app_slot: create content settings for linux function app slot too

[stuartjbrown]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

When using the azurerm_linux_function_app_slot resource, the app settings / environment variables WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING are not created, as they are for the corresponding windows function app slot resource. This appears to break slot swapping between the main and the deployment slot.

The Microsoft documentation is not clear on this but adding these settings manually appears to fix this issue.

fixes: #24901

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_linux_function_app_slot - set WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING settings if not provided [azurerm_linux_function_app_slot WEBSITE_CONTENTSHARE and WEBSITE_CONTENTAZUREFILECONNECTIONSTRING are not created or maintained across applies correctly, causing slot swapping to eventually fail #24901]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #24901

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Thanks for this PR @stuartjbrown.

Looking at the linked issue I have some questions/suggestions around the usage. Would you mind checking out the comment I left and providing some feedback on it?

[github-actions]

This PR is being labeled as "stale" because it has not been updated for 30 or more days.

If this PR is still valid, please remove the "stale" label. If this PR is blocked, please add it to the "Blocked" milestone.

If you need some help completing this PR, please leave a comment letting us know. Thank you!

[stuartjbrown]

Thanks for this PR @stuartjbrown.

Looking at the linked issue I have some questions/suggestions around the usage. Would you mind checking out the comment I left and providing some feedback on it?

Hi @stephybun - thanks for the update. I checked the comments on the issue - we are also doing the slot swap outside of Terraform in an Azure Pipeline. A TF slot swap wouldn't be practical for us as it could have unintended side effects so this fix would still be ideal.

[tj-spyro]

Hi @stephybun, can this be reviewed and merged, please?

In my comment on the issue, Linux function slots are the outlier for how content share is set. Linux function app, Windows function app and Windows slot all have a common behaviour of setting WEBSITE_CONTENTSHARE on Consumption Plans in addition to Elastic Premium.

[stephybun]

Apologies for the long wait on this @stuartjbrown.

The initial issue description and discussion within the team on this led us to believe that there was a deeper behavioural problem here that would require a more involved investigation.

Having finally come back to this and upon re-reading the comments, I see the discrepancy in the check across the four resources. Thanks for doing the digging there @tj-spyro.

LGTM 💯