Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: bump go-azure-sdk to v0.20240321.1145953 #25332

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Mar 20, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

Updating to sdk version with complete data factory swagger fixes/workarounds

Blocked by changes made in Azure/azure-rest-api-specs#28122

@tombuildsstuff
Copy link
Contributor

Looks like the missing model we need does exist in the Swagger: https://github.com/Azure/azure-rest-api-specs/blob/44a81f85be1e4797fbf5e290fc6b41d48788a6ba/specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Credential.json#L98-L116

However this isn't being parsed correctly on the Pandora side, so this will want fixing there - notably this model has multiple parents and is located within a sub-directory.

@manicminer
Copy link
Contributor

Fixes: #25314

@tombuildsstuff tombuildsstuff marked this pull request as ready for review March 21, 2024 15:18
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the checks pass 👍

@tombuildsstuff
Copy link
Contributor

Tests look reasonable 👍

@tombuildsstuff tombuildsstuff merged commit a6de371 into main Mar 21, 2024
30 checks passed
@tombuildsstuff tombuildsstuff deleted the deps/bump-go-azure-sdk-to-v0.20240320.1144505 branch March 21, 2024 16:42
@tombuildsstuff tombuildsstuff added this to the v3.97.0 milestone Mar 21, 2024
tombuildsstuff added a commit that referenced this pull request Mar 21, 2024
@tombuildsstuff tombuildsstuff changed the title dependencies: bump go-azure-sdk to v0.20240320.1144505 dependencies: bump go-azure-sdk to v0.20240321.1145953 Mar 21, 2024
manicminer added a commit that referenced this pull request Mar 21, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation Fault reading storage account with private link
4 participants