azurerm_cosmosdb_account add minimal_tls_version

[rizkybiz]

resolves #21295

[mbfrahry]

Hey @rizkybiz, thanks for opening this PR! It looks good but I've detailed a few extra things to look at before we merge! Let me know if you have any questions!

[mbfrahry]

Is it easy to add a test for this? I think it might be better to pull this out into it's own PR

[bruceharrison1984]

It would be difficult to pull out into it's own PR because it requires minimal_tls_version to be implemented first, otherwise the check wouldn't have purpose. The check just re-sends the original payload so that the TLS version is set correctly on the backend.

It's kind of a chicken/egg scenario, since without Minimal TLS, there's no action to be taken because the value won't be in the state.

So far as writing a test, I believe might it is possible(checking state twice within a single action?) , but we would be checking for the presence of a bug. It would just be checking that the TLS version was first incorrectly set, then correctly set. This might work, but as soon as MS fixes it on their end, that test would break.

[mbfrahry]

This value is update-able so we should test update in this test

[bruceharrison1984]

Added a test for updates

[mbfrahry]

Can we add a todo for 4.0 to add this in as a default?

[bruceharrison1984]

done

[mbfrahry]

Can you share why this was flipped from true to false? It looks like the following is needed but I'm wondering why this needed to be flipped in the first place

 // indices can cause test to be inconsistent
  // I believe there is a bug within the azurerm_cosmosdb_mongo_collection that causes inconsistent results on read
  lifecycle {
    ignore_changes = [
      index
    ]

[bruceharrison1984]

My mistake for altering the original value.

In the context of the test, it doesn't make a difference. The test itself fails due toazurerm_cosmosdb_mongo_collection flagging changes on the indices during the import phase. This occurs whether set to true or false.

        Terraform will perform the following actions:
        
          # azurerm_cosmosdb_mongo_collection.test will be updated in-place
          ~ resource "azurerm_cosmosdb_mongo_collection" "test" {
                id                     = "/subscriptions/...."
                name                   = "acctest-mongodb-coll-240227125500374571"
                # (6 unchanged attributes hidden)
        
              - index {
                  - keys   = [
                      - "_id",
                    ] -> null
                  - unique = true -> null
                }
              + index {
                  + keys   = [
                      + "_id",
                    ]
                  + unique = false
                }
            }

I known @rizkybiz as well as @katbyte both ran into issues on this particular test as well.

Risking this PR becoming stuck due to another resource misbehaving, I opted to ignore the changing property.

[mbfrahry]

So weird! But it does look it's not failing because of these changes! Thanks for following up!

[mbfrahry]

LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.