azurerm_iothub_device_update_account- sku forces new

[ziyeqf]

the sku property is not allowed to change on the service side:

{
    "error": {
        "code": "AccountValidationFailed",
        "details": [
            {
                "code": "AccountSkuChangeNotAllowed",
                "message": "Account SKU change is not allowed after creation"
            }
        ],
        "message": "ValidationException"
    }
}

So update it to force new

test

❯ tftest iothub TestAccIotHubDeviceUpdateAccount    
=== RUN   TestAccIotHubDeviceUpdateAccount_basic
=== PAUSE TestAccIotHubDeviceUpdateAccount_basic
=== RUN   TestAccIotHubDeviceUpdateAccount_complete
=== PAUSE TestAccIotHubDeviceUpdateAccount_complete
=== RUN   TestAccIotHubDeviceUpdateAccount_requiresImport
=== PAUSE TestAccIotHubDeviceUpdateAccount_requiresImport
=== RUN   TestAccIotHubDeviceUpdateAccount_identity
=== PAUSE TestAccIotHubDeviceUpdateAccount_identity
=== RUN   TestAccIotHubDeviceUpdateAccount_publicNetworkAccess
=== PAUSE TestAccIotHubDeviceUpdateAccount_publicNetworkAccess
=== RUN   TestAccIotHubDeviceUpdateAccount_sku
=== PAUSE TestAccIotHubDeviceUpdateAccount_sku
=== RUN   TestAccIotHubDeviceUpdateAccount_tags
=== PAUSE TestAccIotHubDeviceUpdateAccount_tags
=== CONT  TestAccIotHubDeviceUpdateAccount_basic
=== CONT  TestAccIotHubDeviceUpdateAccount_publicNetworkAccess
=== CONT  TestAccIotHubDeviceUpdateAccount_requiresImport
=== CONT  TestAccIotHubDeviceUpdateAccount_tags
=== CONT  TestAccIotHubDeviceUpdateAccount_complete
=== CONT  TestAccIotHubDeviceUpdateAccount_identity
=== CONT  TestAccIotHubDeviceUpdateAccount_sku
--- PASS: TestAccIotHubDeviceUpdateAccount_requiresImport (394.16s)
--- PASS: TestAccIotHubDeviceUpdateAccount_complete (422.90s)
--- PASS: TestAccIotHubDeviceUpdateAccount_basic (449.18s)
--- PASS: TestAccIotHubDeviceUpdateAccount_publicNetworkAccess (561.35s)
--- PASS: TestAccIotHubDeviceUpdateAccount_tags (573.41s)
--- PASS: TestAccIotHubDeviceUpdateAccount_sku (626.16s)
--- PASS: TestAccIotHubDeviceUpdateAccount_identity (847.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/iothub	847.243s

[catriona-m]

Thanks for this @ziyeqf. It looks like there are some test failures here:

------- Stdout: -------
=== RUN   TestAccIotHubDeviceUpdateAccount_complete
=== PAUSE TestAccIotHubDeviceUpdateAccount_complete
=== CONT  TestAccIotHubDeviceUpdateAccount_complete
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        Error: creating Account (Subscription: "*******"
        Resource Group Name: "acctest-rg-240101024459672652"
        Account Name: "acc-dua-6yizb"): performing AccountsCreate: unexpected status 400 with error: AccountValidationFailed: ValidationException
          with azurerm_iothub_device_update_account.test,
          on terraform_plugin_test.tf line 34, in resource "azurerm_iothub_device_update_account" "test":
          34: resource "azurerm_iothub_device_update_account" "test" {
        creating Account (Subscription: "*******"
        Resource Group Name: "acctest-rg-240101024459672652"
        Account Name: "acc-dua-6yizb"): performing AccountsCreate: unexpected status
        400 with error: AccountValidationFailed: ValidationException
--- FAIL: TestAccIotHubDeviceUpdateAccount_complete (119.74s)
FAIL

------- Stdout: -------
=== RUN   TestAccIotHubDeviceUpdateAccount_sku
=== PAUSE TestAccIotHubDeviceUpdateAccount_sku
=== CONT  TestAccIotHubDeviceUpdateAccount_sku
    testcase.go:113: Step 1/4 error: Error running apply: exit status 1
        Error: creating Account (Subscription: "*******"
        Resource Group Name: "acctest-rg-240101024459704280"
        Account Name: "acc-dua-6ow3l"): performing AccountsCreate: unexpected status 400 with error: AccountValidationFailed: ValidationException
          with azurerm_iothub_device_update_account.test,
          on terraform_plugin_test.tf line 28, in resource "azurerm_iothub_device_update_account" "test":
          28: resource "azurerm_iothub_device_update_account" "test" {
        creating Account (Subscription: "*******"
        Resource Group Name: "acctest-rg-240101024459704280"
        Account Name: "acc-dua-6ow3l"): performing AccountsCreate: unexpected status
        400 with error: AccountValidationFailed: ValidationException
--- FAIL: TestAccIotHubDeviceUpdateAccount_sku (108.68s)
FAIL

Given that sku cannot be updated, we should probably remove TestAccIotHubDeviceUpdateAccount_sku. Thanks!

[ziyeqf]

Thanks for this @ziyeqf. It looks like there are some test failures here:

------- Stdout: -------
=== RUN   TestAccIotHubDeviceUpdateAccount_complete
=== PAUSE TestAccIotHubDeviceUpdateAccount_complete
=== CONT  TestAccIotHubDeviceUpdateAccount_complete
    testcase.go:113: Step 1/2 error: Error running apply: exit status 1
        Error: creating Account (Subscription: "*******"
        Resource Group Name: "acctest-rg-240101024459672652"
        Account Name: "acc-dua-6yizb"): performing AccountsCreate: unexpected status 400 with error: AccountValidationFailed: ValidationException
          with azurerm_iothub_device_update_account.test,
          on terraform_plugin_test.tf line 34, in resource "azurerm_iothub_device_update_account" "test":
          34: resource "azurerm_iothub_device_update_account" "test" {
        creating Account (Subscription: "*******"
        Resource Group Name: "acctest-rg-240101024459672652"
        Account Name: "acc-dua-6yizb"): performing AccountsCreate: unexpected status
        400 with error: AccountValidationFailed: ValidationException
--- FAIL: TestAccIotHubDeviceUpdateAccount_complete (119.74s)
FAIL

------- Stdout: -------
=== RUN   TestAccIotHubDeviceUpdateAccount_sku
=== PAUSE TestAccIotHubDeviceUpdateAccount_sku
=== CONT  TestAccIotHubDeviceUpdateAccount_sku
    testcase.go:113: Step 1/4 error: Error running apply: exit status 1
        Error: creating Account (Subscription: "*******"
        Resource Group Name: "acctest-rg-240101024459704280"
        Account Name: "acc-dua-6ow3l"): performing AccountsCreate: unexpected status 400 with error: AccountValidationFailed: ValidationException
          with azurerm_iothub_device_update_account.test,
          on terraform_plugin_test.tf line 28, in resource "azurerm_iothub_device_update_account" "test":
          28: resource "azurerm_iothub_device_update_account" "test" {
        creating Account (Subscription: "*******"
        Resource Group Name: "acctest-rg-240101024459704280"
        Account Name: "acc-dua-6ow3l"): performing AccountsCreate: unexpected status
        400 with error: AccountValidationFailed: ValidationException
--- FAIL: TestAccIotHubDeviceUpdateAccount_sku (108.68s)
FAIL

Given that sku cannot be updated, we should probably remove TestAccIotHubDeviceUpdateAccount_sku. Thanks!

Thanks, I have removed the sku test case, and triggered a run on the TC. They all passed now.

[catriona-m]

Thanks @ziyeqf LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.