Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appconfiguration: using the ListBySubscription endpoint rather than the Resources API #24023

Merged
merged 1 commit into from
Nov 27, 2023
Merged

appconfiguration: using the ListBySubscription endpoint rather than the Resources API #24023

merged 1 commit into from
Nov 27, 2023

Conversation

tombuildsstuff
Copy link
Contributor

Similar to #24019, this PR removes a dependency on the Resources API - plus also caches the Configuration Stores within the Subscription when performing the expensive API call

 $ TF_ACC=1 go test -v ./internal/services/appconfiguration/ -run=TestAccAppConfigurationKey_ -timeout=60m
=== RUN   TestAccAppConfigurationKey_basic
=== PAUSE TestAccAppConfigurationKey_basic
=== RUN   TestAccAppConfigurationKey_basicNoLabel
=== PAUSE TestAccAppConfigurationKey_basicNoLabel
=== RUN   TestAccAppConfigurationKey_complicatedKeyLabel
=== PAUSE TestAccAppConfigurationKey_complicatedKeyLabel
=== RUN   TestAccAppConfigurationKey_basicNoLabel_afterLabel
=== PAUSE TestAccAppConfigurationKey_basicNoLabel_afterLabel
=== RUN   TestAccAppConfigurationKey_basicVault
=== PAUSE TestAccAppConfigurationKey_basicVault
=== RUN   TestAccAppConfigurationKey_KVToVault
=== PAUSE TestAccAppConfigurationKey_KVToVault
=== RUN   TestAccAppConfigurationKey_slash
=== PAUSE TestAccAppConfigurationKey_slash
=== RUN   TestAccAppConfigurationKey_requiresImport
=== PAUSE TestAccAppConfigurationKey_requiresImport
=== RUN   TestAccAppConfigurationKey_lockUpdate
=== PAUSE TestAccAppConfigurationKey_lockUpdate
=== CONT  TestAccAppConfigurationKey_basic
=== CONT  TestAccAppConfigurationKey_KVToVault
=== CONT  TestAccAppConfigurationKey_requiresImport
=== CONT  TestAccAppConfigurationKey_lockUpdate
=== CONT  TestAccAppConfigurationKey_basicNoLabel_afterLabel
=== CONT  TestAccAppConfigurationKey_basicNoLabel
=== CONT  TestAccAppConfigurationKey_slash
=== CONT  TestAccAppConfigurationKey_basicVault
=== CONT  TestAccAppConfigurationKey_complicatedKeyLabel
--- PASS: TestAccAppConfigurationKey_basic (541.93s)
--- PASS: TestAccAppConfigurationKey_slash (542.46s)
--- PASS: TestAccAppConfigurationKey_basicNoLabel (552.76s)
--- PASS: TestAccAppConfigurationKey_basicNoLabel_afterLabel (553.81s)
--- PASS: TestAccAppConfigurationKey_lockUpdate (554.28s)
--- PASS: TestAccAppConfigurationKey_complicatedKeyLabel (554.60s)
--- PASS: TestAccAppConfigurationKey_requiresImport (556.74s)
--- PASS: TestAccAppConfigurationKey_basicVault (716.52s)
--- PASS: TestAccAppConfigurationKey_KVToVault (720.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/appconfiguration	721.264s

@tombuildsstuff
appconfiguration: using the ListBySubscription endpoint rather than t…
741f90c 
…he Resources API

This removes a dependency on the Resources API - plus also caches the Configuration Stores within the Subscription
when performing the expensive API call
@tombuildsstuff tombuildsstuff added this to the v3.83.0 milestone Nov 24, 2023
@tombuildsstuff tombuildsstuff requested a review from a team November 24, 2023 16:40
@tombuildsstuff tombuildsstuff changed the title appconfiguration: using the ListBySubscription endpoint rather than the Resources API appconfiguration: using the ListBySubscription endpoint rather than the Resources API Nov 24, 2023
@tombuildsstuff tombuildsstuff mentioned this pull request Nov 24, 2023
Merged
jackofallops
jackofallops approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 3ffc36f into main Nov 27, 2023
21 checks passed
@tombuildsstuff tombuildsstuff deleted the refactor/appconfiguration-use-listbysubscription branch November 27, 2023 13:45
osfidelity pushed a commit to fidelity-contributions/hashicorp-terraform-provider-azurerm-archive that referenced this pull request Nov 27, 2023
@tombuildsstuff
d/private_dns_zone: refactoring to use the ListBySubscription API rat…
9890c54 
…her than the Resources API

Similar to hashicorp#24023 and hashicorp#24019 this PR refactors the Private DNS Zone data source to use the ListBySubscription API
rather than listing on the Resources API.

This should both improve reliability, since we're no longer hitting the Resources API (which can serve stale data)
but also removes another usage of `Azure/azure-sdk-for-go`
@teowa teowa mentioned this pull request Dec 5, 2023
Open
1 task
@wuxu92 wuxu92 mentioned this pull request Feb 28, 2024
Open
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
refactor service/app-configuration size/M
Projects
None yet
Milestone
v3.83.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @jackofallops