Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage resource manager client update SDK: 2022-05-01 to 2023-01-01 #23543

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Storage resource manager client update SDK: 2022-05-01 to 2023-01-01 #23543

merged 1 commit into from
Oct 13, 2023

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Oct 13, 2023 •
edited
Loading

Update the go-azure-sdk for storage client from 2022-05-01 to 2023-01-01.

The main motivation is to support new properties introduced in the latest API (e.g. #23020)

Test

terraform-provider-azurerm on  storage_sdk_20220501_to_20230101 via 🐹 v1.21.1 took 1m10s
💢  TF_ACC=1 go test -v -timeout=20h -run='TestAccLocalUser_|TestAccStorageEncryptionScope_|TestAccStorageManagementPolicy_|TestAccStorageObjectReplication_' ./internal/services/storage
=== RUN   TestAccLocalUser_passwordOnly
=== PAUSE TestAccLocalUser_passwordOnly
=== RUN   TestAccLocalUser_sshKeyOnly
=== PAUSE TestAccLocalUser_sshKeyOnly
=== RUN   TestAccLocalUser_passwordAndSSHKey
=== PAUSE TestAccLocalUser_passwordAndSSHKey
=== RUN   TestAccLocalUser_homeDirectory
=== PAUSE TestAccLocalUser_homeDirectory
=== RUN   TestAccLocalUser_permissionScope
=== PAUSE TestAccLocalUser_permissionScope
=== RUN   TestAccLocalUser_requiresImport
=== PAUSE TestAccLocalUser_requiresImport
=== RUN   TestAccStorageEncryptionScope_keyVaultKey
=== PAUSE TestAccStorageEncryptionScope_keyVaultKey
=== RUN   TestAccStorageEncryptionScope_keyVaultKeyVersionless
=== PAUSE TestAccStorageEncryptionScope_keyVaultKeyVersionless
=== RUN   TestAccStorageEncryptionScope_keyVaultKeyRequireInfrastructureEncryption
=== PAUSE TestAccStorageEncryptionScope_keyVaultKeyRequireInfrastructureEncryption
=== RUN   TestAccStorageEncryptionScope_keyVaultKeyUpdate
=== PAUSE TestAccStorageEncryptionScope_keyVaultKeyUpdate
=== RUN   TestAccStorageEncryptionScope_keyVaultKeyToMicrosoftManagedKey
=== PAUSE TestAccStorageEncryptionScope_keyVaultKeyToMicrosoftManagedKey
=== RUN   TestAccStorageEncryptionScope_microsoftManagedKeyToKeyVaultManagedKey
=== PAUSE TestAccStorageEncryptionScope_microsoftManagedKeyToKeyVaultManagedKey
=== RUN   TestAccStorageEncryptionScope_microsoftManagedKey
=== PAUSE TestAccStorageEncryptionScope_microsoftManagedKey
=== RUN   TestAccStorageEncryptionScope_microsoftManagedKeyRequireInfrastructureEncryption
=== PAUSE TestAccStorageEncryptionScope_microsoftManagedKeyRequireInfrastructureEncryption
=== RUN   TestAccStorageEncryptionScope_requiresImport
=== PAUSE TestAccStorageEncryptionScope_requiresImport
=== RUN   TestAccStorageManagementPolicy_basic
=== PAUSE TestAccStorageManagementPolicy_basic
=== RUN   TestAccStorageManagementPolicy_requiresImport
=== PAUSE TestAccStorageManagementPolicy_requiresImport
=== RUN   TestAccStorageManagementPolicy_singleAction
=== PAUSE TestAccStorageManagementPolicy_singleAction
=== RUN   TestAccStorageManagementPolicy_singleActionUpdate
=== PAUSE TestAccStorageManagementPolicy_singleActionUpdate
=== RUN   TestAccStorageManagementPolicy_multipleRule
=== PAUSE TestAccStorageManagementPolicy_multipleRule
=== RUN   TestAccStorageManagementPolicy_updateMultipleRule
=== PAUSE TestAccStorageManagementPolicy_updateMultipleRule
=== RUN   TestAccStorageManagementPolicy_blobTypes
=== PAUSE TestAccStorageManagementPolicy_blobTypes
=== RUN   TestAccStorageManagementPolicy_blobIndexMatch
=== PAUSE TestAccStorageManagementPolicy_blobIndexMatch
=== RUN   TestAccStorageManagementPolicy_complete
=== PAUSE TestAccStorageManagementPolicy_complete
=== RUN   TestAccStorageManagementPolicy_zero
=== PAUSE TestAccStorageManagementPolicy_zero
=== RUN   TestAccStorageManagementPolicy_update
=== PAUSE TestAccStorageManagementPolicy_update
=== RUN   TestAccStorageManagementPolicy_baseblobAccessTimeBased
=== PAUSE TestAccStorageManagementPolicy_baseblobAccessTimeBased
=== RUN   TestAccStorageObjectReplication_basic
=== PAUSE TestAccStorageObjectReplication_basic
=== RUN   TestAccStorageObjectReplication_requiresImport
=== PAUSE TestAccStorageObjectReplication_requiresImport
=== RUN   TestAccStorageObjectReplication_complete
=== PAUSE TestAccStorageObjectReplication_complete
=== RUN   TestAccStorageObjectReplication_update
=== PAUSE TestAccStorageObjectReplication_update
=== RUN   TestAccStorageObjectReplication_crossTenantDisabled
=== PAUSE TestAccStorageObjectReplication_crossTenantDisabled
=== RUN   TestAccStorageObjectReplication_crossSubscription
    storage_object_replication_resource_test.go:142: The secondary subscription is not specified
--- SKIP: TestAccStorageObjectReplication_crossSubscription (0.00s)
=== CONT  TestAccLocalUser_passwordOnly
=== CONT  TestAccStorageManagementPolicy_requiresImport
=== CONT  TestAccStorageEncryptionScope_keyVaultKeyRequireInfrastructureEncryption
=== CONT  TestAccStorageManagementPolicy_zero
=== CONT  TestAccStorageObjectReplication_requiresImport
=== CONT  TestAccStorageManagementPolicy_updateMultipleRule
=== CONT  TestAccStorageManagementPolicy_multipleRule
=== CONT  TestAccStorageManagementPolicy_basic
=== CONT  TestAccStorageEncryptionScope_requiresImport
=== CONT  TestAccStorageObjectReplication_crossTenantDisabled
=== CONT  TestAccStorageObjectReplication_update
=== CONT  TestAccStorageObjectReplication_complete
--- PASS: TestAccStorageManagementPolicy_basic (82.87s)
=== CONT  TestAccLocalUser_permissionScope
--- PASS: TestAccStorageManagementPolicy_multipleRule (145.97s)
=== CONT  TestAccStorageEncryptionScope_keyVaultKeyVersionless
--- PASS: TestAccStorageManagementPolicy_zero (147.80s)
=== CONT  TestAccStorageEncryptionScope_keyVaultKey
--- PASS: TestAccStorageManagementPolicy_requiresImport (152.63s)
=== CONT  TestAccLocalUser_requiresImport
--- PASS: TestAccLocalUser_passwordOnly (153.55s)
=== CONT  TestAccLocalUser_passwordAndSSHKey
--- PASS: TestAccStorageObjectReplication_crossTenantDisabled (165.90s)
=== CONT  TestAccLocalUser_homeDirectory
--- PASS: TestAccStorageObjectReplication_complete (167.66s)
=== CONT  TestAccStorageEncryptionScope_microsoftManagedKeyToKeyVaultManagedKey
--- PASS: TestAccStorageManagementPolicy_updateMultipleRule (170.47s)
=== CONT  TestAccStorageEncryptionScope_microsoftManagedKeyRequireInfrastructureEncryption
--- PASS: TestAccStorageObjectReplication_requiresImport (175.82s)
=== CONT  TestAccStorageEncryptionScope_microsoftManagedKey
--- PASS: TestAccLocalUser_requiresImport (106.96s)
=== CONT  TestAccStorageManagementPolicy_singleActionUpdate
--- PASS: TestAccLocalUser_permissionScope (207.18s)
=== CONT  TestAccStorageManagementPolicy_blobIndexMatch
--- PASS: TestAccLocalUser_homeDirectory (164.79s)
=== CONT  TestAccStorageManagementPolicy_complete
--- PASS: TestAccStorageObjectReplication_update (334.66s)
=== CONT  TestAccStorageManagementPolicy_baseblobAccessTimeBased
--- PASS: TestAccStorageEncryptionScope_requiresImport (360.38s)
=== CONT  TestAccStorageObjectReplication_basic
--- PASS: TestAccStorageEncryptionScope_keyVaultKeyRequireInfrastructureEncryption (374.95s)
=== CONT  TestAccLocalUser_sshKeyOnly
--- PASS: TestAccLocalUser_passwordAndSSHKey (242.74s)
=== CONT  TestAccStorageManagementPolicy_singleAction
--- PASS: TestAccStorageManagementPolicy_singleActionUpdate (164.77s)
=== CONT  TestAccStorageEncryptionScope_keyVaultKeyToMicrosoftManagedKey
--- PASS: TestAccStorageManagementPolicy_complete (142.45s)
=== CONT  TestAccStorageEncryptionScope_keyVaultKeyUpdate
--- PASS: TestAccStorageEncryptionScope_keyVaultKey (372.24s)
=== CONT  TestAccStorageManagementPolicy_blobTypes
--- PASS: TestAccStorageEncryptionScope_microsoftManagedKeyRequireInfrastructureEncryption (351.55s)
=== CONT  TestAccStorageManagementPolicy_update
--- PASS: TestAccStorageObjectReplication_basic (161.93s)
--- PASS: TestAccStorageEncryptionScope_keyVaultKeyVersionless (378.63s)
--- PASS: TestAccStorageManagementPolicy_singleAction (142.76s)
--- PASS: TestAccStorageEncryptionScope_microsoftManagedKey (363.57s)
--- PASS: TestAccStorageManagementPolicy_blobIndexMatch (253.58s)
--- PASS: TestAccStorageEncryptionScope_microsoftManagedKeyToKeyVaultManagedKey (396.07s)
--- PASS: TestAccLocalUser_sshKeyOnly (212.68s)
--- PASS: TestAccStorageManagementPolicy_baseblobAccessTimeBased (270.20s)
--- PASS: TestAccStorageManagementPolicy_blobTypes (140.67s)
--- PASS: TestAccStorageManagementPolicy_update (152.91s)
--- PASS: TestAccStorageEncryptionScope_keyVaultKeyToMicrosoftManagedKey (387.32s)
--- PASS: TestAccStorageEncryptionScope_keyVaultKeyUpdate (408.04s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       881.228s

tombuildsstuff
tombuildsstuff approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v3.77.0 milestone Oct 13, 2023
@tombuildsstuff tombuildsstuff merged commit 5538d4f into hashicorp:main Oct 13, 2023
20 checks passed
tombuildsstuff added a commit that referenced this pull request Oct 13, 2023
@tombuildsstuff
updating to include #23543
a5e15bc
dduportal pushed a commit to jenkins-infra/azure that referenced this pull request Oct 20, 2023
@jenkins-infra-updatecli @jenkins-infra-bot
Bump Terraform azurerm provider version to 3.77.0 (#500)
106e45d 
<Actions>
<action
id="4a39167e811ac038e4a588362092472c27cfbe9e4929ae61d035f708a093a669">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azurerm&#34; updated from &#34;3.76.0&#34; to
&#34;3.77.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.77.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.77.0&#xA;FEATURES:&#xA;&#xA;*
New Resources: `azurerm_application_load_balancer_frontend`
([#23411](hashicorp/terraform-provider-azurerm#23411
New Resources: `azurerm_dev_center`
([#23538](hashicorp/terraform-provider-azurerm#23538
New Resources: `azurerm_dev_center_project`
([#23538](https://github.com/hashicorp/terraform-provider-azurerm/issues/23538))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.62.0` of
`github.com/hashicorp/go-azure-helpers`
([#23581](hashicorp/terraform-provider-azurerm#23581
dependencies: updating Kusto SDK from `2023-05-02` to `2023-08-15`
([#23598](hashicorp/terraform-provider-azurerm#23598
dependencies: updating nginx from `2022-08-01` to `2023-04-01`
([#23583](hashicorp/terraform-provider-azurerm#23583
`netapp`: updating to use API Version `2023-05-01`
([#23576](hashicorp/terraform-provider-azurerm#23576
`springcloud`: updating to use API Version `2023-09-01-preview`
([#23544](hashicorp/terraform-provider-azurerm#23544
`storage`: updating to use API Version `2023-01-01`
([#23543](hashicorp/terraform-provider-azurerm#23543
`internal/sdk`: fixing an issue where struct fields containing
`removedInNextMajorVersion` wouldn&#39;t be decoded correctly
([#23564](hashicorp/terraform-provider-azurerm#23564
`internal/sdk`: struct tag parsing is now handled consistently during
both encoding and decoding
([#23568](hashicorp/terraform-provider-azurerm#23568
provider: the `roll_instances_when_required` provider feature in the
`virtual_machine_scale_set` block is now optional
([#22976](hashicorp/terraform-provider-azurerm#22976
Data Source: `azurerm_automation_account`: refactoring the remaining
usage of `Azure/azure-sdk-for-go` to use `hashicorp/go-azure-sdk`
([#23555](hashicorp/terraform-provider-azurerm#23555
`azurerm_automation_account`: refactoring the remaining usage of
`Azure/azure-sdk-for-go` to use `hashicorp/go-azure-sdk`
([#23555](hashicorp/terraform-provider-azurerm#23555
`azurerm_resource_deployment_script_azure_cli` - improve validation for
the `version` property to support newer versions
([#23370](hashicorp/terraform-provider-azurerm#23370
`azurerm_resource_deployment_script_azure_power_shell` - improve
validation for the `version` property to support newer versions
([#23370](hashicorp/terraform-provider-azurerm#23370
`azurerm_nginx_deployment` - support for the `capacity` and `email`
properties
([#23596](https://github.com/hashicorp/terraform-provider-azurerm/issues/23596))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* Data Source: `azurerm_virtual_hub_connection` - export
the `inbound_route_map_id`, `outbound_route_map_id`, and
`static_vnet_local_route_override_criteria` attributes in the `routing`
block, and fix a bug where these attributes could not be set
([#23491](hashicorp/terraform-provider-azurerm#23491
`azurerm_cdn_frontdoor_rule` - the `url_filename_condition` properties
`match_values` is now optional if `operator` is set to `Any`
([#23541](hashicorp/terraform-provider-azurerm#23541
`azurerm_shared_image_gallery` - added the `Private` and `Groups`
options for the `sharing.permission` property
([#23570](hashicorp/terraform-provider-azurerm#23570
`azurerm_redis_cache` - fixed incorrect ssl values for
`redis_primary_connection_string` and `secondary_connection_string`
([#23575](hashicorp/terraform-provider-azurerm#23575
`azurerm_monitor_activity_log_alert` - the `recommend_category` property
now can be set to `HighAvailability`
([#23605](hashicorp/terraform-provider-azurerm#23605
`azurerm_recovery_services_vault` - the `encryption` property can now be
used with the `cross_region_restore_enabled` property
([#23618](hashicorp/terraform-provider-azurerm#23618
`azurerm_storage_account_customer_managed_key` - prevent a panic when
the keyvault id is empty
([#23599](https://github.com/hashicorp/terraform-provider-azurerm/issues/23599))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
dependencies service/storage size/XL
Projects
None yet
Milestone
v3.77.0
Development

Successfully merging this pull request may close these issues.
2 participants
@magodo @tombuildsstuff