Feature: MySQL Flex Server Auto IOPS Scaling #23391
Conversation
There was a problem hiding this comment.
Hey @Siddarthyuvaraj, this looks good but the tests are failing due to missing attributes. I've detailed more down below
| @@ -989,6 +990,7 @@ resource "azurerm_mysql_flexible_server" "test" { | |||
| size_gb = %d | |||
| iops = %d | |||
| auto_grow_enabled = %t | |||
| iops_auto_scaling = %t | |||
| } | |||
| } | |||
| `, r.template(data), data.RandomInteger, sizeGB, iops, enabled) | |||
There was a problem hiding this comment.
This test is failing as it's missing an argument down below
| `, r.template(data), data.RandomInteger, sizeGB, iops, enabled) | |
| `, r.template(data), data.RandomInteger, sizeGB, iops, enabled, enabled) |
| @@ -989,6 +990,7 @@ resource "azurerm_mysql_flexible_server" "test" { | |||
| size_gb = %d | |||
| iops = %d | |||
| auto_grow_enabled = %t | |||
| iops_auto_scaling = %t | |||
There was a problem hiding this comment.
This isn't lined up properly
| iops_auto_scaling = %t | |
| iops_auto_scaling = %t |
| @@ -704,6 +704,7 @@ resource "azurerm_mysql_flexible_server" "test" { | |||
| size_gb = 32 | |||
| iops = 400 | |||
| auto_grow_enabled = false | |||
| iops_auto_scaling = false | |||
There was a problem hiding this comment.
And here
| iops_auto_scaling = false | |
| iops_auto_scaling = false |
|
Hi @mbfrahry i have made the changes. Please run the tests and let me know if any further changes required from my end. Thank you. |
|
Thanks for this PR @Siddarthyuvaraj. Unfortunately we overlooked another PR that's already been opened to add this property. Since the other PR was opened earlier and is already in active review I'm going to close this one in favour of #23329. Apologies for the confusion and thanks again for your contribution! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
No description provided.