Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: log instead of error when RPs are unavailable when validating RP registrations #23380

Merged
merged 3 commits into from
Nov 2, 2023
Merged

provider: log instead of error when RPs are unavailable when validating RP registrations #23380

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4c70a3
provider: work around RP unavailability in some non-public clouds whe…
manicminer Sep 25, 2023
63a3e43
Address review
mbfrahry Nov 2, 2023
3ae1e3a
Remove unneeded environment atrribute from method call
mbfrahry Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/resourceproviders/requiring_registration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package resourceproviders

import (
"fmt"
"log"
)

// DetermineWhichRequiredResourceProvidersRequireRegistration determines which Resource Providers require registration to be able to be used
Expand All @@ -20,8 +21,8 @@ func DetermineWhichRequiredResourceProvidersRequireRegistration(requiredResource
}

if _, isUnregistered := (*unregisteredResourceProviders)[providerName]; !isUnregistered {
// this is likely a typo in the Required Resource Providers list, so we should surface this
return nil, fmt.Errorf("the required Resource Provider %q wasn't returned from the Azure API", providerName)
// some RPs may not exist in some non-public clouds, so we'll log a warning here instead of raising an error
log.Printf("[WARN] The required Resource Provider %q wasn't returned from the Azure API", providerName)
}

requiringRegistration = append(requiringRegistration, providerName)
Expand Down
Loading