azurerm_api_management_diagnostic - prevent sending operationNameFormat field for azuremoniton diagnostic
#22545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
service/api-management
size/S
waiting-response
labels
github-actions
bot
added
size/XS
and removed
waiting-response
dependencies
size/S
labels
catriona-m
reviewed
Jul 25, 2023
| @@ -113,7 +113,6 @@ func resourceApiManagementDiagnostic() *pluginsdk.Resource { | |||
| "operation_name_format": { | |||
| Type: pluginsdk.TypeString, | |||
| Optional: true, | |||
| Default: string(apimanagement.OperationNameFormatName), | |||
There was a problem hiding this comment.
it would be a breaking change to remove the default here as this could break things for existing users who are using this default. However, we could potentially use the features.FourPointOhBeta() flag here so that the remove default can be optionally used. There are some examples of the flag being used in the contributors guide here
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure API does not allow to sent
operationNameFormatfield while creating/updatingazuremonitondiagnostic. This field is required only forapplicationinsights.It's not possible to create
azuremonitordiagnostic right now because of the error:Fixes #19970