Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault_certificate: expose arm resource id #21314

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Apr 6, 2023

resolves: #21261

this just works as keyvault secret:

d.Set("resource_id", parse.NewSecretID(keyVaultId.SubscriptionId, keyVaultId.ResourceGroup, keyVaultId.Name, id.Name, id.Version).ID())
d.Set("resource_versionless_id", parse.NewSecretVersionlessID(keyVaultId.SubscriptionId, keyVaultId.ResourceGroup, keyVaultId.Name, id.Name).ID())

--- PASS: TestAccKeyVaultCertificate_basicImportPFX (440.87s)
PASS
--- PASS: TestAccDataSourceKeyVaultCertificate_basic (437.98s)
PASS

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 - some minor remarks and the docs also need to be updated but otherwise this looks good.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for renaming those @wuxu92. Docs still need to be updated before we can merge this!

@wuxu92
Copy link
Contributor Author

wuxu92 commented Apr 12, 2023

sorry i just forgot it. a new push updated the documents.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 LGTM 💯

@stephybun stephybun merged commit 4e065b7 into hashicorp:main Apr 12, 2023
@github-actions github-actions bot added this to the v3.52.0 milestone Apr 12, 2023
stephybun added a commit that referenced this pull request Apr 12, 2023
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for exporting Azure resource identifier for azurerm_key_vault_certificate
2 participants