Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_windows_web_app,azurerm_windows_web_app_slot, azurerm_windows_function_app, azurerm_windows_function_app_slot, azurerm_linux_web_app,azurerm_linux_web_app_slot, azurerm_linux_function_app, azurerm_linux_function_app_slot - fix ip_restriction,scm_ip_restriction block cannot be removed issue #20327

Closed
wants to merge 2 commits into from

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Feb 6, 2023

fix #18793
fix #18664
fix #20331

--- PASS: TestAccWindowsWebApp_withIPRestrictions (354.81s)
--- PASS: TestAccWindowsWebApp_withIPRestrictionsUpdate (821.52s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appservice    822.239s

There is a default value for ip_restriction, we need to deal with it when user removes the block, otherwise, the set value cannot be override by null.

@github-actions github-actions bot added size/L and removed size/S labels Feb 7, 2023
@xiaxyi xiaxyi changed the title azurerm_windows_web_app,azurerm_windows_web_app_slot, azurerm_windows_function_app, azurerm_windows_function_app_slot, azurerm_linux_web_app,azurerm_linux_web_app_slot, azurerm_linux_function_app, azurerm_linux_function_app_slot - fix ip_restriction block cannot be removed issue azurerm_windows_web_app,azurerm_windows_web_app_slot, azurerm_windows_function_app, azurerm_windows_function_app_slot, azurerm_linux_web_app,azurerm_linux_web_app_slot, azurerm_linux_function_app, azurerm_linux_function_app_slot - fix ip_restriction,scm_ip_restriction block cannot be removed issue Feb 7, 2023
@jackofallops
Copy link
Member

Thanks for this @xiaxyi - I'm going to close this due to an underlying fix being present in 20987.

Thanks again

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants