Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resouece] - azurerm_machine_learning_datastore_datalake_gen1 #20026

Closed
wants to merge 28 commits into from

Conversation

xuzhang3
Copy link
Contributor

New resource azurerm_machine_learning_datastore_datalake_gen1 - Machine learning Data Lake Gen1 data store, This PR depends: #19909

=== RUN   TestAccMachineLearningDataStoreDataLakeGen1_basic
=== PAUSE TestAccMachineLearningDataStoreDataLakeGen1_basic
=== RUN   TestAccMachineLearningDataStoreDataLakeGen1_spn
=== PAUSE TestAccMachineLearningDataStoreDataLakeGen1_spn
=== RUN   TestAccMachineLearningDataStoreDataLakeGen1_requiresImport
=== PAUSE TestAccMachineLearningDataStoreDataLakeGen1_requiresImport
=== CONT  TestAccMachineLearningDataStoreDataLakeGen1_basic
=== CONT  TestAccMachineLearningDataStoreDataLakeGen1_requiresImport
=== CONT  TestAccMachineLearningDataStoreDataLakeGen1_spn
--- PASS: TestAccMachineLearningDataStoreDataLakeGen1_spn (490.86s)
--- PASS: TestAccMachineLearningDataStoreDataLakeGen1_basic (561.97s)
--- PASS: TestAccMachineLearningDataStoreDataLakeGen1_requiresImport (583.72s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/machinelearning       618.951s

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xuzhang3 - As mentioned offline, can you take a look at converting this to a Typed resource.

Thanks!

@xuzhang3
Copy link
Contributor Author

@jackofallops working on it

@xuzhang3
Copy link
Contributor Author

xuzhang3 commented Jan 18, 2023

@jackofallops Thanks for reviewing this PR. Refactored into typed resource.

"github.com/hashicorp/terraform-provider-azurerm/utils"
)

type MachineLearningDataStoreDataLakeGen1 struct{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuzhang3 Gen1 is deprecated and we've removed support for this in 3.0 since you can no longer provision new accounts: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/3.0-upgrade-guide#resource-azurerm_data_share_dataset_data_lake_gen1

https://learn.microsoft.com/en-gb/azure/storage/blobs/data-lake-storage-migrate-gen1-to-gen2

What's the use-case for adding this resource, given new instances can't be created and the Service is entirely removed next year?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tombuildsstuff this resource was generated based on the data store types. @deeikele do we need to support gen1 resources as this service will be deprecated soon?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuzhang3 No, there's no need to support gen1

@xuzhang3
Copy link
Contributor Author

Close this PR as gen1 service will be deprecated.
https://learn.microsoft.com/en-gb/azure/storage/blobs/data-lake-storage-migrate-gen1-to-gen2

@xuzhang3 xuzhang3 closed this Jan 19, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
@xuzhang3 xuzhang3 deleted the f/datastore_gen1 branch August 14, 2024 02:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants