-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resouece] - azurerm_machine_learning_datastore_datalake_gen1
#20026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xuzhang3 - As mentioned offline, can you take a look at converting this to a Typed resource.
Thanks!
@jackofallops working on it |
@jackofallops Thanks for reviewing this PR. Refactored into typed resource. |
"github.com/hashicorp/terraform-provider-azurerm/utils" | ||
) | ||
|
||
type MachineLearningDataStoreDataLakeGen1 struct{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuzhang3 Gen1 is deprecated and we've removed support for this in 3.0 since you can no longer provision new accounts: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/guides/3.0-upgrade-guide#resource-azurerm_data_share_dataset_data_lake_gen1
https://learn.microsoft.com/en-gb/azure/storage/blobs/data-lake-storage-migrate-gen1-to-gen2
What's the use-case for adding this resource, given new instances can't be created and the Service is entirely removed next year?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tombuildsstuff this resource was generated based on the data store types. @deeikele do we need to support gen1 resources as this service will be deprecated soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xuzhang3 No, there's no need to support gen1
Close this PR as gen1 service will be deprecated. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
New resource
azurerm_machine_learning_datastore_datalake_gen1
- Machine learning Data Lake Gen1 data store, This PR depends: #19909