Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_nginx_configuration #18761

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Oct 14, 2022

add support for nignx configuration resource. Related API

=== RUN   TestAccConfiguration_basic
=== PAUSE TestAccConfiguration_basic
=== CONT  TestAccConfiguration_basic
--- PASS: TestAccConfiguration_basic (618.20s)
=== RUN   TestAccConfiguration_update
=== PAUSE TestAccConfiguration_update
=== CONT  TestAccConfiguration_update
--- PASS: TestAccConfiguration_update (745.40s)
PASS

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @wuxu92

Thanks for this PR - I've taken a look through and left some comments inline, if we can fix those up then we should be able to take another look here.

Thanks!

internal/services/nginx/nginx_configuration_resource.go Outdated Show resolved Hide resolved
internal/services/nginx/nginx_configuration_resource.go Outdated Show resolved Hide resolved
internal/services/nginx/nginx_configuration_resource.go Outdated Show resolved Hide resolved
internal/services/nginx/nginx_configuration_resource.go Outdated Show resolved Hide resolved
internal/services/nginx/nginx_configuration_resource.go Outdated Show resolved Hide resolved
website/docs/r/nginx_configuration.html.markdown Outdated Show resolved Hide resolved
website/docs/r/nginx_configuration.html.markdown Outdated Show resolved Hide resolved
website/docs/r/nginx_configuration.html.markdown Outdated Show resolved Hide resolved
website/docs/r/nginx_configuration.html.markdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 - LGTM 🆖

@katbyte katbyte merged commit 9a8d235 into hashicorp:main Oct 24, 2022
katbyte added a commit that referenced this pull request Oct 24, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 24, 2022
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
@wuxu92 wuxu92 deleted the nginx/conf branch March 5, 2024 05:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants