Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects diff supression for linked storage accounts #18547

Closed

Conversation

Nepomuceno
Copy link
Contributor

Just adding diff supression.
Fix for #18546

@katbyte
Copy link
Collaborator

katbyte commented Sep 28, 2022

I think this will be fixed by #18547?

@Nepomuceno
Copy link
Contributor Author

I dont get this pr it is the #18547 no ?

@Nepomuceno Nepomuceno force-pushed the fix-18546-liked-sotrage-account branch from 4de47c5 to 0e36d33 Compare September 28, 2022 06:17
@katbyte
Copy link
Collaborator

katbyte commented Sep 28, 2022

whoops, sorry bad copy paste: #18116

@katbyte
Copy link
Collaborator

katbyte commented Sep 28, 2022

on main this line is now added when not in 4.0 mode:
image

@Nepomuceno
Copy link
Contributor Author

Makes sense! It was not there yesterday :)
after rebase I am having errors but it is probably related to #18556
will close this one and also add the link to the pr that fixed it in the issue.
By the way didn't know that you could add properties to the schema this way, it is interesssing but I found it a bit harder to read.

@Nepomuceno Nepomuceno closed this Sep 28, 2022
@katbyte
Copy link
Collaborator

katbyte commented Sep 29, 2022

@Nepomuceno - we try not to but it is the easiest way to handle the 4.0 flag so when we release 4.0 we just have to flip the flag and can slowly remove the old code over time

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants