-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_kubernetes_cluster
- making linux_profile
optional
#1821
Commits on Aug 24, 2018
-
🐛 (Linux profile of AKS.) Make linux_profile be optional.
The AKS API does not require linux_profile to be set by default, this is enabled by default on Azure portal. Terraform's schema does not align with this, which causes importing issue.
Configuration menu - View commit details
-
Copy full SHA for cc64845 - Browse repository at this point
Copy the full SHA cc64845View commit details -
💚 (Import test of AKS.) Pass empty string to refactored function.
Pass empty string to refactored function in import test of AKS.
Configuration menu - View commit details
-
Copy full SHA for db8ec61 - Browse repository at this point
Copy the full SHA db8ec61View commit details -
💚 (Basic test of AKS.) Missing the linux_profile configuration string.
Added the linux_profile configuration string while baking the configuration.
Configuration menu - View commit details
-
Copy full SHA for 535c434 - Browse repository at this point
Copy the full SHA 535c434View commit details -
💚 (Basic test of AKS.) Remove useless basic test with linux profile.
Remove the basic test with linux profile to avoid string concat issue.
Configuration menu - View commit details
-
Copy full SHA for 30280d6 - Browse repository at this point
Copy the full SHA 30280d6View commit details -
🐛 (Linux profile of AKS.) Make linux_profile be computed.
linux_profile needs to be computed since it's optional. Otherwise, return `terraform plan` will warn with change.
Configuration menu - View commit details
-
Copy full SHA for 966a0e6 - Browse repository at this point
Copy the full SHA 966a0e6View commit details
Commits on Aug 25, 2018
-
🐛 (AKS resource.) Return empty array if profile is nil.
If the response of field is not returned in response body, need to return empty array.
Configuration menu - View commit details
-
Copy full SHA for c10542f - Browse repository at this point
Copy the full SHA c10542fView commit details
Commits on Aug 29, 2018
-
✅ (Tests for AKS.) Add 2 tests for linuxProfile of AKS.
Add 2 tests to have more coverage on linuxProfile specific scenarios.
Configuration menu - View commit details
-
Copy full SHA for 2704c65 - Browse repository at this point
Copy the full SHA 2704c65View commit details -
♻️ (Test code for AKS.) Refactor the test code for AKS.
Removed useless linux_profile and kubernetes_version settings for tests.
Configuration menu - View commit details
-
Copy full SHA for e091e40 - Browse repository at this point
Copy the full SHA e091e40View commit details -
🚨 (Import test for AKS.) Fix the go fmt error.
Add newline to import test file for AKS.
Configuration menu - View commit details
-
Copy full SHA for e76e1c2 - Browse repository at this point
Copy the full SHA e76e1c2View commit details
Commits on Aug 30, 2018
-
💚 (Resource tests for AKS.) Fix the path issue for linux_profile.
Fix the path issue to correct naming for linux_profile.
Configuration menu - View commit details
-
Copy full SHA for 095ddf6 - Browse repository at this point
Copy the full SHA 095ddf6View commit details