Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - making linux_profile optional #1821

Merged
merged 10 commits into from
Aug 30, 2018

Commits on Aug 24, 2018

  1. 🐛 (Linux profile of AKS.) Make linux_profile be optional.

    The AKS API does not require linux_profile to be set by default, this is enabled by default on Azure
    portal. Terraform's schema does not align with this, which causes importing issue.
    metacpp committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    cc64845 View commit details
    Browse the repository at this point in the history
  2. 💚 (Import test of AKS.) Pass empty string to refactored function.

    Pass empty string to refactored function in import test of AKS.
    metacpp committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    db8ec61 View commit details
    Browse the repository at this point in the history
  3. 💚 (Basic test of AKS.) Missing the linux_profile configuration string.

    Added the linux_profile configuration string while baking the configuration.
    metacpp committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    535c434 View commit details
    Browse the repository at this point in the history
  4. 💚 (Basic test of AKS.) Remove useless basic test with linux profile.

    Remove the basic test with linux profile to avoid string concat issue.
    metacpp committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    30280d6 View commit details
    Browse the repository at this point in the history
  5. 🐛 (Linux profile of AKS.) Make linux_profile be computed.

    linux_profile needs to be computed since it's optional. Otherwise, return `terraform plan` will warn
    with change.
    metacpp committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    966a0e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2018

  1. 🐛 (AKS resource.) Return empty array if profile is nil.

    If the response of field is not returned in response body, need to return empty array.
    metacpp committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    c10542f View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2018

  1. ✅ (Tests for AKS.) Add 2 tests for linuxProfile of AKS.

    Add 2 tests to have more coverage on linuxProfile specific scenarios.
    metacpp committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    2704c65 View commit details
    Browse the repository at this point in the history
  2. ♻️ (Test code for AKS.) Refactor the test code for AKS.

    Removed useless linux_profile and kubernetes_version settings for tests.
    metacpp committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    e091e40 View commit details
    Browse the repository at this point in the history
  3. 🚨 (Import test for AKS.) Fix the go fmt error.

    Add newline to import test file for AKS.
    metacpp committed Aug 29, 2018
    Configuration menu
    Copy the full SHA
    e76e1c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2018

  1. 💚 (Resource tests for AKS.) Fix the path issue for linux_profile.

    Fix the path issue to correct naming for linux_profile.
    metacpp committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    095ddf6 View commit details
    Browse the repository at this point in the history