azurerm_site_recovery_replicated_vm - support 'target_availability_zone' argument

[cheng514]

Added 'target_availability_zone' argument for zone-zone diaster recovery support for VM using azurerm_site_recovery_replicated_vm.

(fixes #14652)

[cheng514]

For issue #14652

[tombuildsstuff]

hi @cheng514

Thanks for this PR.

Taking a look through whilst this is off to a good start, we're making Zones consistent across the Provider in 3.0 (more details can be found in #14588) - as such we'll need to bring this into line with those changes (and add some tests) - but if we can fix those up then this should otherwise be good to go 👍

Thanks!

[cheng514]

Hi @tombuildsstuff , thank you so much for your review. I have made changes accordingly and added tests. Please review again and let me know if there are any other issues. Thanks!

[myc2h6o]

Test result looks good:

[tombuildsstuff]

LGTM 👍

[katbyte]

CI needs to be fixed up @myc2h6o

[myc2h6o]

Hi @katbyte I've helped with resolving the linting issue. And the vendor dependencies check is failing due to the breaking change of the combination of compute 11-01 upgrade and go sdk version 62.1.0 upgrade. It shall be fixed by #15729

[cheng514]

Hi @tombuildsstuff and @katbyte, hope you are well, and thank you for your help reviewing this PR. I see that this PR has been moved to the v3.0.0 milestone. As we are expecting to use this feature soon for our workloads, and our modules are not ready for the v3.0.0 major release, I'm wondering if there are any more minor versions that might be released before v3.0.0? If possible, could we please add this feature into one of the v2 minor releases? Much appreciated!

[katbyte]

@myc2h6o - CI is still failing here?

@cheng514 - we will not be doing any more 2.x releases, 2.99 is the last one.

[myc2h6o]

Hi @katbyte I though the dependencies check would merge the branch with main then check, but seems like it checks the branch itself. The fix was on main already, @cheng514 could you merge the latest main and see if it helps?

[katbyte]

LGTM 🦀

[github-actions]

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.