Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: consistent identity blocks - appservice / web #15363

Merged
merged 15 commits into from
Feb 11, 2022
Merged

refactor: consistent identity blocks - appservice / web #15363

merged 15 commits into from
Feb 11, 2022

Conversation

tombuildsstuff
Copy link
Contributor

The final part of #15187

@tombuildsstuff
r/static_site: refactoring to use the common identity schema
4873240
@tombuildsstuff
appservice/legacy: refactoring the identity types to use the common s…
d01a21b 
…chema in 3.0
@tombuildsstuff
appservice: refactoring to use the common identity schema
79bf5c2
@tombuildsstuff
r/windows_web_app_slot: adding a test covering identity end to end
883b1e8
@tombuildsstuff
appservice: implementing the expand/flatten functions
533c41d
@tombuildsstuff
r/windows_web_app: adding tests covering the identity lifecycle
74a9880
@tombuildsstuff
r/windows_function_app_slot: adding tests for identity
cead9e1
@tombuildsstuff
r/windows_function_app: adding tests covering identity
ded3b58
@tombuildsstuff
r/linux_web_app_slot: adding tests for identity end to end
aca7c3d
@tombuildsstuff
tests: example -> test
1a24c7f
@tombuildsstuff
r/linux_web_app: adding tests for the identity block
9740899
@tombuildsstuff
r/linux_function_app_slot: adding tests covering the identity block
dc86eef
@tombuildsstuff
r/linux_function_app: adding tests covering the identity block
ce844fb
@tombuildsstuff tombuildsstuff added this to the v2.96.0 milestone Feb 10, 2022
@tombuildsstuff tombuildsstuff requested review from a team and jackofallops and removed request for a team February 10, 2022 12:52
jackofallops
jackofallops approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - just one comment below, otherwise LGTM 👍

internal/services/appservice/windows_web_app_slot_resource.go Show resolved Hide resolved
@tombuildsstuff tombuildsstuff modified the milestones: v2.96.0, v2.97.0 Feb 11, 2022
@tombuildsstuff tombuildsstuff merged commit 3558a9a into main Feb 11, 2022
@tombuildsstuff tombuildsstuff deleted the f/consistent-identity-blocks-appservice branch February 11, 2022 09:11
@github-actions
Copy link

This functionality has been released in v2.97.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackofallops jackofallops jackofallops approved these changes

Assignees
No one assigned
Labels
refactor service/app-service size/XL
Projects
None yet
Milestone
v2.97.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @jackofallops