Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain_service: export resource_id attribute #13011

Merged
merged 2 commits into from
Aug 17, 2021
Merged

domain_service: export resource_id attribute #13011

merged 2 commits into from
Aug 17, 2021

Conversation

manicminer
Copy link
Contributor

The Terraform resource ID has additional metadata making it unsuitable to reference in other resources, so export the resource ID returned by the api as resource_id for this purpose.

Example: https://github.com/hashicorp/terraform-provider-azurerm/pull/12866/files#diff-392307fe377786872660f8d0a471da23536615bfda62865290dc0738dad437bbR238

@manicminer manicminer added this to the v2.73.0 milestone Aug 16, 2021
@manicminer manicminer requested a review from a team August 16, 2021 12:56
katbyte
katbyte approved these changes Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manicminer - looks good aside from the docs need updating ✨

@manicminer
Copy link
Contributor Author

Doh! Thanks @katbyte :)

@manicminer manicminer merged commit 600d4b7 into main Aug 17, 2021
@manicminer manicminer deleted the r/aadds-resource-id branch August 17, 2021 21:53
manicminer added a commit that referenced this pull request Aug 17, 2021
@manicminer
Changelog for #13011
9223699
@github-actions
Copy link

This functionality has been released in v2.73.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/domain-services size/XS
Projects
None yet
Milestone
v2.73.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @katbyte