azurerm_app_service - support for the acr_use_managed_identity_creds and acr_user_managed_identity_id properties
#12399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozts2005
changed the title
mozts2005
changed the title
mozts2005
changed the title
- support for the acr_use_managed_identity_creds and acr_user_managed_identity_id` properties
mozts2005
changed the title
- support for the acr_use_managed_identity_creds and acr_user_managed_identity_id` propertiesazurerm_app_service - support for the acr_use_managed_identity_creds and acr_user_managed_identity_id properties
jackofallops
reviewed
Jul 7, 2021
…version in docs (hashicorp#12525) fixes hashicorp#10183
… for consumer_group (hashicorp#12523) fixes hashicorp#11958
Co-authored-by: kt <[email protected]>
…corp#12508) * Updated documentation * Reverted documentation change for subnet resource id. Change will be done in separate PR.
* Current progress * Enable CMK working * Add validation for cmk * Add nil check for amlWorkspaceID * Attempt to fix complete test case * remove maxitems from storage_account_identity * Fix lint errors * Modify test TestAccDatabricksWorkspace_update * Remove the set for ui_definition_uri * Update test cases * Add test cases for new attributes * Fixing test again * Commenting out unused test code for now * Update azurerm/internal/services/databricks/databricks_workspace_resource.go Co-authored-by: kt <[email protected]> * Update azurerm/internal/services/databricks/databricks_workspace_resource.go Co-authored-by: kt <[email protected]> * Update azurerm/internal/services/databricks/databricks_workspace_resource.go Co-authored-by: kt <[email protected]> * Address PR comments... * Update validation checks * Fix lint error * Refactoring validation for readability * Refactor the world * Fixing my dyslexia in my uber comment... * Update tests * Bug fix * Moved managed CMK code * Remove computed from custom_parameters * Revert update to custom_parameters * Enable CMK tests * Middle of massive refactor to new resource * Moved to new resource * terrafmt documentation * Fix test case * Add new step to test case * Update import test * Update import test * Update importer setId * Additional test updates * Fix lint errors * Import fix * moved cmk out of custom params * terrafmt * Another terrafmt * Update tests to validate parent resource * Update CMK to always pass all custom params * Fixing my dyslexia again * Update delete to pass all params * Add dependency on CMK for access policy * Wait a minute... Strike that. Reverse it. * no_public_ip cannot be changed once set * Fix invalid update and infra tests * Fix test cleanup configurations * Fix update test as everything is force new * Trying unhook the associations so destroy works * Remove just the subnet delegation * Delete the NSG first the the delegation * Remove assoc order * Modify step one of cleanup * Disable no public ip in clean up * remove deprecated attributes from tests * Documentation update only... * Remove the local specific URL from the docs... * Address PR comments * Force databricks deletion first * Remove fix for broken tests * add workspace dependency on nsg * Strike that, reverse it... * Not the NSG the NSGA Co-authored-by: kt <[email protected]>
|
Hi @mozts2005, thanks for this PR, just to quickly answer the SDK/Notes point:
When we update the SDK, all viable versions of the API for each are available, however, we don't automatically upgrade to the latest API version for services, that is a separate deliberate step to help prevent breaking change as different API versions are not guaranteed to be compatible. The PR you referred to takes that step, and I'm in the process of reviewing and running it through our regression suite. Once that's merged, you'll be able to rebase this PR here against master to pick up the missing items and we'll be able to review, until then I'm afraid this PR is blocked. |
…ig-data-plane Embedding a Data Plane SDK for AppConfiguration
…dentity-export Note for accessing Identity exports on azurerm_function_app
|
I am going to close this PR to Create a new one so that I have clean base and for some reason my rebase will just fast-forward. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a fix for issue #12277
Depends on #12635