azurerm_virtual_machine_scale_set DS - adjust the schemas to be Computed
#11712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
katbyte
pushed a commit
that referenced
this pull request
May 16, 2021
Running the XS003 rule against the master branch and got following warnings: /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/compute/virtual_machine_scale_set.go:449:17: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/consumption/schema.go:185:13: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/consumption/schema.go:203:13: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/media/media_asset_filter_resource.go:69:31: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/media/media_asset_filter_resource.go:113:23: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/media/media_asset_filter_resource.go:118:20: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/mssql/migration/database_v0_to_v1.go:107:34: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/web/app_service.go:877:16: XS003: schema might introduce crash or diff as it allows to be an empty block This PR fixes all the warnings above, except the vmss one, which is covered in #11712.
|
This has been released in version 2.60.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.60.0"
}
# ... other configuration ... |
favoretti
pushed a commit
to gro1m/terraform-provider-azurerm
that referenced
this pull request
May 26, 2021
Running the XS003 rule against the master branch and got following warnings: /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/compute/virtual_machine_scale_set.go:449:17: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/consumption/schema.go:185:13: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/consumption/schema.go:203:13: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/media/media_asset_filter_resource.go:69:31: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/media/media_asset_filter_resource.go:113:23: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/media/media_asset_filter_resource.go:118:20: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/mssql/migration/database_v0_to_v1.go:107:34: XS003: schema might introduce crash or diff as it allows to be an empty block /home/magodo/github/terraform-provider-azurerm-secondary/azurerm/internal/services/web/app_service.go:877:16: XS003: schema might introduce crash or diff as it allows to be an empty block This PR fixes all the warnings above, except the vmss one, which is covered in hashicorp#11712.
favoretti
pushed a commit
to gro1m/terraform-provider-azurerm
that referenced
this pull request
May 26, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor issue caused by #10585