Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_registry - add quarantine policy property to container registry #11011

Conversation

ms-henglu
Copy link
Contributor

Below paste the run pass result for the test cases

=== RUN   TestAccContainerRegistry_policies
=== PAUSE TestAccContainerRegistry_policies
=== CONT  TestAccContainerRegistry_policies
--- PASS: TestAccContainerRegistry_policies (294.62s)
PASS

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ms-henglu

Thanks for this PR.

Taking a look through here whilst this looks to support this functionality, we can reduce this to a top-level boolean rather than having this as a nested block - as such can we update this?

Thanks!

@ghost ghost added size/S and removed size/M labels Mar 23, 2021
@ms-henglu ms-henglu force-pushed the branch-00000-add-quarantine-policy-property-to-container-registry branch from ee5768b to d54f994 Compare March 23, 2021 01:44
@ms-henglu
Copy link
Contributor Author

@tombuildsstuff I have added a commit, please review again. Thanks!

@ghost ghost removed the waiting-response label Mar 23, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from one comment this LGTM 👍

website/docs/r/container_registry.html.markdown Outdated Show resolved Hide resolved
@katbyte katbyte added this to the v2.53.0 milestone Mar 25, 2021
@ms-henglu
Copy link
Contributor Author

Thanks for code review!

@ms-henglu
Copy link
Contributor Author

It seems there's a conflict after #10969 merged, I'll fix it.

@ms-henglu ms-henglu force-pushed the branch-00000-add-quarantine-policy-property-to-container-registry branch from 374af10 to 3c10800 Compare March 25, 2021 04:58
@ms-henglu
Copy link
Contributor Author

@katbyte , I have fixed the conflicts, please check. Thanks!

@jackofallops jackofallops modified the milestones: v2.53.0, v2.54.0 Mar 26, 2021
@katbyte katbyte merged commit 572fa33 into hashicorp:master Mar 30, 2021
katbyte added a commit that referenced this pull request Mar 30, 2021
@ghost
Copy link

ghost commented Apr 2, 2021

This has been released in version 2.54.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.54.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 30, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2021
@ms-henglu ms-henglu deleted the branch-00000-add-quarantine-policy-property-to-container-registry branch May 6, 2021 05:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants