-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_container_registry - add quarantine policy property to container registry #11011
azurerm_container_registry - add quarantine policy property to container registry #11011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @ms-henglu
Thanks for this PR.
Taking a look through here whilst this looks to support this functionality, we can reduce this to a top-level boolean rather than having this as a nested block - as such can we update this?
Thanks!
azurerm/internal/services/containers/container_registry_resource.go
Outdated
Show resolved
Hide resolved
ee5768b
to
d54f994
Compare
@tombuildsstuff I have added a commit, please review again. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from one comment this LGTM 👍
Thanks for code review! |
It seems there's a conflict after #10969 merged, I'll fix it. |
…ce.go Co-authored-by: Tom Harvey <[email protected]>
374af10
to
3c10800
Compare
@katbyte , I have fixed the conflicts, please check. Thanks! |
This has been released in version 2.54.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.54.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Below paste the run pass result for the test cases