azurerm_storage_share set metadata Computed and set acl start and expiry Optional

[yupwei68]

Fix azurerm_storage_sync_cloud_endpoint acctest problems, #8540

[mbfrahry]

Hey @yupwei68, can you go into a little detail about why we're making MetaData computed. I can see that you're doing a lifecycle ignore in the PR you linked but I didn't see how it was affecting that resource.

Also can you write a test to confirm that we can create a storage share with an ACL but not setting expiry and start. We'll also want to update the documentation as well

[yupwei68]

Hi @mbfrahry here's the metadata will be changed once we have created a azurerm_storage_sync_cloud_endpoint with reference to it.

 After applying this step and refreshing, the plan was not empty:
        
        DIFF:
        
        UPDATE: azurerm_storage_share.test
          ...
          metadata.azurebackupprotected:     "False" => ""
          metadata.postbackupuri:            "/subscriptions/.../resourceGroups/.../providers/microsoft.storagesync/storageSyncServices/.../syncGroups/.../cloudEndpoints/.../postbackup?api-version=2017-06-05-preview" => ""
          metadata.postrestoreuri:           "/subscriptions/..../resourceGroups/.../providers/microsoft.storagesync/storageSyncServices/.../syncGroups/.../cloudEndpoints/..../postrestore?api-version=2017-06-05-preview" => ""
          metadata.prebackupuri:             "/subscriptions/.../resourceGroups/.../providers/microsoft.storagesync/storageSyncServices/.../syncGroups/.../cloudEndpoints/.../prebackup?api-version=2017-06-05-preview" => ""
          metadata.prerestoreuri:            "/subscriptions/.../resourceGroups/.../providers/microsoft.storagesync/storageSyncServices/.../syncGroups/.../cloudEndpoints/.../prerestore?api-version=2017-06-05-preview" => ""
          metadata.restoreheartbeaturi:      "/subscriptions/.../resourceGroups/.../providers/microsoft.storagesync/storageSyncServices/.../syncGroups/.../cloudEndpoints/.../restoreheartbeat?api-version=2017-06-05-preview" => ""
          metadata.syncgroup:                "..." => ""
          metadata.syncservice:              "..." => ""
          metadata.syncsignature:            "...." => ""
          ...
        

[yupwei68]

@mbfrahry THanks for your comments. An additional test has been added. Please continue reviewing.
=== RUN TestAccAzureRMStorageShare_aclGhostedRecall
=== PAUSE TestAccAzureRMStorageShare_aclGhostedRecall
=== CONT TestAccAzureRMStorageShare_aclGhostedRecall
--- PASS: TestAccAzureRMStorageShare_aclGhostedRecall (134.55s)

[mbfrahry]

LGTM! Thanks for taking the time to explain the metadata issue @yupwei68

[ghost]

This has been released in version 2.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.32.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!