azurerm_storage_share - set metadata to Computed and set acl …

…`start` and `expiry` to `Optional` (#8811)

azurerm/internal/services/storage/resource_arm_storage_share.go

@@ -69,7 +69,7 @@ func resourceArmStorageShare() *schema.Resource {
 				ValidateFunc: validation.IntBetween(1, 102400),
 			},
 
-			"metadata": MetaDataSchema(),
+			"metadata": MetaDataComputedSchema(),
 
 			"acl": {
 				Type:     schema.TypeSet,
@@ -88,12 +88,12 @@ func resourceArmStorageShare() *schema.Resource {
 								Schema: map[string]*schema.Schema{
 									"start": {
 										Type:         schema.TypeString,
-										Required:     true,
+										Optional:     true,
 										ValidateFunc: validation.StringIsNotEmpty,
 									},
 									"expiry": {
 										Type:         schema.TypeString,
-										Required:     true,
+										Optional:     true,
 										ValidateFunc: validation.StringIsNotEmpty,
 									},
 									"permissions": {

azurerm/internal/services/storage/tests/resource_arm_storage_share_test.go

@@ -152,6 +152,25 @@ func TestAccAzureRMStorageShare_acl(t *testing.T) {
 	})
 }
 
+func TestAccAzureRMStorageShare_aclGhostedRecall(t *testing.T) {
+	data := acceptance.BuildTestData(t, "azurerm_storage_share", "test")
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:     func() { acceptance.PreCheck(t) },
+		Providers:    acceptance.SupportedProviders,
+		CheckDestroy: testCheckAzureRMStorageShareDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccAzureRMStorageShare_aclGhostedRecall(data),
+				Check: resource.ComposeTestCheckFunc(
+					testCheckAzureRMStorageShareExists(data.ResourceName),
+				),
+			},
+			data.ImportStep(),
+		},
+	})
+}
+
 func TestAccAzureRMStorageShare_updateQuota(t *testing.T) {
 	data := acceptance.BuildTestData(t, "azurerm_storage_share", "test")
 
@@ -376,6 +395,25 @@ resource "azurerm_storage_share" "test" {
 `, template, data.RandomString)
 }
 
+func testAccAzureRMStorageShare_aclGhostedRecall(data acceptance.TestData) string {
+	template := testAccAzureRMStorageShare_template(data)
+	return fmt.Sprintf(`
+%s
+
+resource "azurerm_storage_share" "test" {
+  name                 = "testshare%s"
+  storage_account_name = azurerm_storage_account.test.name
+
+  acl {
+    id = "GhostedRecall"
+    access_policy {
+      permissions = "r"
+    }
+  }
+}
+`, template, data.RandomString)
+}
+
 func testAccAzureRMStorageShare_aclUpdated(data acceptance.TestData) string {
 	template := testAccAzureRMStorageShare_template(data)
 	return fmt.Sprintf(`

website/docs/r/storage_share.html.markdown

@@ -72,13 +72,13 @@ A `acl` block supports the following:
 
 A `access_policy` block supports the following:
 
-* `expiry` - (Required) The time at which this Access Policy should be valid until, in [ISO8601](https://en.wikipedia.org/wiki/ISO_8601) format.
-
 * `permissions` - (Required) The permissions which should be associated with this Shared Identifier. Possible value is combination of `r` (read), `w` (write), `d` (delete), and `l` (list).
 
 ~> **Note:** Permission order is strict at the service side, and permissions need to be listed in the order above. 
 
-* `start` - (Required) The time at which this Access Policy should be valid from, in [ISO8601](https://en.wikipedia.org/wiki/ISO_8601) format.
+* `start` - (Optional) The time at which this Access Policy should be valid from, in [ISO8601](https://en.wikipedia.org/wiki/ISO_8601) format.
+
+* `expiry` - (Optional) The time at which this Access Policy should be valid until, in [ISO8601](https://en.wikipedia.org/wiki/ISO_8601) format.
 
 ## Attributes Reference