Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_registry - support for trust_policy and retention_policy #8698

Merged
merged 7 commits into from
Oct 15, 2020

Conversation

notchairmk
Copy link
Member

@notchairmk notchairmk commented Sep 30, 2020

Adds policies block to azurerm_container_registry for setting trust_policy and retention_policy.

Azure doesn't support upgrading to Premium SKU and setting attributes specific to Premium SKUs simultaneously. This PR breaks the client update calls into two separate areas.

Closes #8485

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr @notchairmk - overall this looks good but i have some UX concerns around the schema as well as the order of API calls being made. I think it would be less code changes and API calls to do the SKU updates at the same time as before, and then make a separate API call afterwards to update the policies? WDYT? reread PR description and this make sense now 🙂

@notchairmk notchairmk requested a review from katbyte October 5, 2020 22:42
@notchairmk
Copy link
Member Author

Updated and all PR comments should have been addressed. Thanks!

@ghost ghost removed the waiting-response label Oct 9, 2020
@katbyte katbyte added this to the v2.32.0 milestone Oct 15, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @notchairmk - this LGTM now 👍

@katbyte katbyte merged commit b6432e5 into hashicorp:master Oct 15, 2020
katbyte added a commit that referenced this pull request Oct 15, 2020
@ghost
Copy link

ghost commented Oct 15, 2020

This has been released in version 2.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 14, 2020
@notchairmk notchairmk deleted the acr_policy branch December 26, 2020 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for [No Resource or feature for ACR retention policy]
2 participants