Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for [No Resource or feature for ACR retention policy] #8485

Closed
xitos2019 opened this issue Sep 16, 2020 · 2 comments · Fixed by #8698
Closed

Support for [No Resource or feature for ACR retention policy] #8485

xitos2019 opened this issue Sep 16, 2020 · 2 comments · Fixed by #8698

Comments

@xitos2019
Copy link

xitos2019 commented Sep 16, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Will be helpful to to have ACR retention "enable" feature as we dont see any feature or ARM resource for ACR retention.
at the moment we can only enable retention policy from Azure Portal.

New or Affected Resource(s)

  • azurerm_2.17

Potential Terraform Configuration

resource "azurerm_container_registry" "acr" {
  name                     = "containerRegistry1"
  resource_group_name      = azurerm_resource_group.rg.name
  location                 = azurerm_resource_group.rg.location
  sku                      = "Premium"
  admin_enabled            = false
  georeplication_locations = ["East US", "West Europe"]
}

References

  • #0000
@xitos2019 xitos2019 changed the title Support for [ACR retention ARM resource for ] Support for [No Resource or feature for ACR retention policy] Sep 16, 2020
katbyte added a commit that referenced this issue Oct 15, 2020
Adds policies block to azurerm_container_registry for setting trust_policy and retention_policy.

Azure doesn't support upgrading to Premium SKU and setting attributes specific to Premium SKUs simultaneously. This PR breaks the client update calls into two separate areas.

Closes #8485
@katbyte katbyte added this to the v2.32.0 milestone Oct 15, 2020
@ghost
Copy link

ghost commented Oct 15, 2020

This has been released in version 2.32.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.32.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants