Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_share allow large quotas to be specified. #8666

Merged
merged 10 commits into from
Oct 8, 2020

Conversation

mbfrahry
Copy link
Member

@mbfrahry mbfrahry commented Sep 28, 2020

(fixes #4552)

@mbfrahry mbfrahry changed the title azurerm_storage_share allow large quotas to be specified. [WIP] azurerm_storage_share allow large quotas to be specified. Sep 28, 2020
@mbfrahry mbfrahry changed the title [WIP] azurerm_storage_share allow large quotas to be specified. azurerm_storage_share allow large quotas to be specified. Sep 29, 2020
@mbfrahry mbfrahry changed the title azurerm_storage_share allow large quotas to be specified. [WIP] azurerm_storage_share allow large quotas to be specified. Sep 29, 2020
@BHoggs
Copy link
Contributor

BHoggs commented Oct 1, 2020

Would it also be possible to add "Large File Shares" support to azurerm_storage_account to support this? Otherwise this isn't possible without using a premium storage account

@mbfrahry mbfrahry changed the title [WIP] azurerm_storage_share allow large quotas to be specified. azurerm_storage_share allow large quotas to be specified. Oct 8, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mbfrahry mbfrahry added this to the v2.31.0 milestone Oct 8, 2020
@mbfrahry mbfrahry merged commit 4ac0ae7 into master Oct 8, 2020
@mbfrahry mbfrahry deleted the u-giovanni-sdk-13 branch October 8, 2020 16:56
mbfrahry added a commit that referenced this pull request Oct 8, 2020
@ghost
Copy link

ghost commented Oct 8, 2020

This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

az premium files max at 5T (vs 100T)
3 participants