Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

az premium files max at 5T (vs 100T) #4552

Closed
surlypants opened this issue Oct 7, 2019 · 8 comments · Fixed by #8666
Closed

az premium files max at 5T (vs 100T) #4552

surlypants opened this issue Oct 7, 2019 · 8 comments · Fixed by #8666

Comments

@surlypants
Copy link

surlypants commented Oct 7, 2019

Given an azure premium files storage account, TF (0.12.9) constrains the quota/sizing between 100M and 5T, whereas the portal allows 100M - 100T.

attempting to supply (in TF) a quota > 50120 yields:

Invalid input: input.QuotaInGB must be greater than 0, and less than/equal to 5TB (5120 GB)

100T portal creation validated by az cli:

az storage share list --account-name ${my_premium_files_SA} | grep quota
"quota": 102400

TF:

  • provider.azuread: version = "~> 0.6"
  • provider.azurerm: version = "~> 1.35"
  • provider.external: version = "~> 1.2"
  • provider.null: version = "~> 2.1"
  • provider.random: version = "~> 2.2"
@surlypants
Copy link
Author

surlypants commented Oct 9, 2019

per: https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/vendor/github.com/tombuildsstuff/giovanni/storage/2018-11-09/file/shares/properties_set.go

	if newQuotaGB <= 0 || newQuotaGB > 5120 {
		return result, validation.NewError("shares.Client", "SetProperties", "`newQuotaGB` must be greater than 0, and less than/equal to 5TB (5120 GB)")
	}

and per: https://github.com/terraform-providers/terraform-provider-azurerm/blob/master/vendor/github.com/tombuildsstuff/giovanni/storage/2018-11-09/file/shares/create.go

	if input.QuotaInGB <= 0 || input.QuotaInGB > 5120 {
		return result, validation.NewError("shares.Client", "Create", "`input.QuotaInGB` must be greater than 0, and less than/equal to 5TB (5120 GB)")
	}

current ARM indicates min to be 100 and max to be 102400

I've recompiled master, editing the above, but cannot figure out how to get terragrunt to 'trust' this updated provider build.

@katbyte
Copy link
Collaborator

katbyte commented Oct 10, 2019

Hi @surlypants,

if you open a PR on the giovanni we can get it merged and into 1.36 🙂

@surlypants
Copy link
Author

surlypants commented Oct 15, 2019

the appropriate fix will need to case between std and premium storage, where std allowed values are 1-5120, and premium allowed values are 100-102400

left a note at giovanni (tombuildsstuff/giovanni#18)

@surlypants
Copy link
Author

std files now also needs 100T:

https://azure.microsoft.com/en-us/blog/announcing-the-general-availability-of-larger-more-powerful-standard-file-shares-for-azure-files/

@BzSpi
Copy link
Contributor

BzSpi commented Oct 18, 2019

For the standard tier, the large file share flag must be enabled, so additional configuration is expected.

https://docs.microsoft.com/en-us/azure/storage/files/storage-files-how-to-create-large-file-share

@rem-aj

This comment has been minimized.

@ghost
Copy link

ghost commented Oct 8, 2020

This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants