Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/app_configuration: support for UserAssigned & SystemAssigned, UserAssigned identities #8177

Closed
MattMencel opened this issue Aug 19, 2020 · 7 comments · Fixed by #13080
Closed

Comments

@MattMencel
Copy link
Contributor

MattMencel commented Aug 19, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Please add the identity block to azurerm_app_configuration. It looks to me like it's supported by the API.

I think it is implemented similar to how it's done in the azurerm_app_service resource.

New or Affected Resource(s)

  • azurerm_app_configuration

Potential Terraform Configuration

resource "azurerm_user_assigned_identity" "example" {
  name                = "example-id"
  resource_group_name = var.resource_group_name
  location            = var.locations
}

resource "azurerm_app_configuration" "example" {
  name                = "example-appconfig"
  resource_group_name = var.resource_group_name
  location            = var.location
  sku                 = "standard"

  identity {
    type = "UserAssigned" # or SystemAssigned
    identity_ids = [azurerm_user_assigned_identity.example.client_id] # Required only if UserAssigned. Not sure if it will be client_id or principal_id here.
  }
}

References

@jongio
Copy link

jongio commented Sep 1, 2020

I ran into this today as well. Would love to see this implemented.

azsdke2e

@realrubberduckdev
Copy link

Would love to see this implemented as well.

If it helps anyone, I am using a workaround using az cli:

resource "null_resource" "app_configuration_managed_identity" {
  provisioner "local-exec" {
    command = "az appconfig identity assign -g ${local.resource_group_name} -n ${local.app_configuration_name)}"
  }
}

@tombuildsstuff tombuildsstuff changed the title Support for identity block in azurerm_app_configuration r/app_configuration: support for UserAssigned & SystemAssigned, UserAssigned Jan 4, 2021
@tombuildsstuff tombuildsstuff changed the title r/app_configuration: support for UserAssigned & SystemAssigned, UserAssigned r/app_configuration: support for UserAssigned & SystemAssigned, UserAssigned identities Jan 4, 2021
@arestarh
Copy link
Contributor

arestarh commented Jan 13, 2021

@favoretti Some time ago support of SystemAssigned user identity was added to azurerm_app_configuration. Thanks.
Could you please take a look here regarding support of UserAssigned use identity ?

@favoretti
Copy link
Collaborator

@arestarh As much as I'm trying to help the community out, I'm primarily quite selfish here and implement mostly the stuff we use. Can't promise that it will happen soon but if noone beats me to it, I will try to have a look.

@tombuildsstuff
Copy link
Contributor

API upgrade is tracked in #10176

favoretti added a commit to favoretti/terraform-provider-azurerm that referenced this issue Aug 20, 2021
favoretti added a commit to favoretti/terraform-provider-azurerm that referenced this issue Aug 23, 2021
@katbyte katbyte added this to the v2.74.0 milestone Aug 26, 2021
katbyte pushed a commit that referenced this issue Aug 26, 2021
@github-actions
Copy link

This functionality has been released in v2.74.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants