Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FQDN for azurerm_firewall_network_rule_collection #7743

Closed
2mol opened this issue Jul 14, 2020 · 5 comments · Fixed by #8878
Closed

FQDN for azurerm_firewall_network_rule_collection #7743

2mol opened this issue Jul 14, 2020 · 5 comments · Fixed by #8878
Assignees
Labels
enhancement sdk/not-yet-supported Support for this does not exist in the upstream SDK at this time service/firewall
Milestone

Comments

@2mol
Copy link

2mol commented Jul 14, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Azure Firewall now supports setting FQDN rules (rules based on domain names) directly under the Network Rules. This is in addition to IP address rules and Service Tags.

It would be great to be able to set FQDN rules via Terraform.

For context, Network Security Groups accept strings like service tags in the destination address fields.

New or Affected Resource(s)

  • azurerm_firewall_network_rule_collection
@annerajb
Copy link

No wonder I can't find it <_<.

Would also love to be able to set this on Terraform

@magodo
Copy link
Collaborator

magodo commented Jul 15, 2020

@2mol and @annerajb Thank you for submitting this 👍
In order to enable FQDN on network rules, one will need to enable DNS proxy on the firewall.

Both functionalities are now in the preview state, accordingly, there is no dedicated property defined, for example, DNS setting. Instead, the current API put those settings in the additionalProperties, which is not ideal to be involved in provider codebase, unfortunately.

After this functionality is stabalized in API, then we shall begin to implement that.

@magodo magodo added enhancement sdk/not-yet-supported Support for this does not exist in the upstream SDK at this time labels Jul 15, 2020
@annerajb
Copy link

annerajb commented Jul 15, 2020 via email

@ghost
Copy link

ghost commented Nov 5, 2020

This has been released in version 2.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.35.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement sdk/not-yet-supported Support for this does not exist in the upstream SDK at this time service/firewall
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants