-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty 'administrator_login_password' in azurerm_mariadb_server data source #6521
Comments
Azure MariaDB data source was fixed in the last release (https://github.com/terraform-providers/terraform-provider-azurerm/issues/6483) but maybe this password was missed. |
hey @rmaziarka Thanks for opening this issue. Taking a look through here the password won't be returned from the Azure API here for security reasons - as such this field probably shouldn't have been added to this data source. As such we should instead look to remove this field from this resource ( Thanks! |
Hey @tombuildsstuff, Let me disagree with you. For example with data sources:
Therefore you provide this information for other services as well. Moreover removing this from the data source would force me to pass the password to the output (I am using a connection to MariaDB cluster from a different state). And it doesn't sound much secure than having it in the data source. |
@rmaziarka different API's behave in different ways - for AKS and CosmosDB (and Storage Accounts etc) they provide a means of obtaining these tokens - unfortunately the Database API's (e.g. MariaDB/MySql/Postgres/SQL Server) don't return this field, so there's nothing for us to output from the API here - which is why this field wants removing Hope that helps clarify that :) |
OK, now it is clear :) |
- `create_mode`, `creation_source_server_id` - Support replicas and point-in-time restores - Use booleans for toggle properties, renaming * `auto_grow` -> `auto_grow_enabled` * `geo_redundant_backup` -> `geo_redundant_backup_enabled` * `ssl_enforcement` -> `ssl_enforcement_enabled` - Remove redundant `storage_profile` block and move all properties within to top level - Remove unpopulated attribute `administrator_login_password` from `mariadb_server` data source Fixes: #4296, #6521 Related: #6459
- `create_mode`, `creation_source_server_id` - Support replicas and point-in-time restores - Use booleans for toggle properties, renaming * `auto_grow` -> `auto_grow_enabled` * `geo_redundant_backup` -> `geo_redundant_backup_enabled` * `ssl_enforcement` -> `ssl_enforcement_enabled` - Remove redundant `storage_profile` block and move all properties within to top level - Remove unpopulated attribute `administrator_login_password` from `mariadb_server` data source Fixes: #4296, #6521 Related: #6459
- `create_mode`, `creation_source_server_id`, `public_network_access_enabled` - Support replicas and point-in-time restores - Use booleans for toggle properties, renaming * `auto_grow` -> `auto_grow_enabled` * `geo_redundant_backup` -> `geo_redundant_backup_enabled` * `ssl_enforcement` -> `ssl_enforcement_enabled` - Remove redundant `storage_profile` block and move all properties within to top level - Remove unpopulated attribute `administrator_login_password` from `mariadb_server` data source Fixes: #4296, #6521 Related: #6459
closed by #6865 |
This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.10.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Community Note
Terraform (and AzureRM Provider) Version
Affected Resource(s)
azurerm_mariadb_server
Terraform Configuration Files
Expected Behavior
In output I should get:
`mariadb_server_password = "password"
Actual Behavior
I get no information in output.
Steps to Reproduce
terraform apply -auto-approve
Additional information
In terraform state file I have null value for password:
The text was updated successfully, but these errors were encountered: