Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management_diagnostic doesn't link to logger #6104

Closed
evertonmc opened this issue Mar 13, 2020 · 2 comments · Fixed by #6682
Closed

azurerm_api_management_diagnostic doesn't link to logger #6104

evertonmc opened this issue Mar 13, 2020 · 2 comments · Fixed by #6682

Comments

@evertonmc
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider)

  • azurerm 2.0.0

Affected Resource(s)

  • azurerm_api_management_diagnostic

Expected Behavior

  • api calls should be traced to an AI instance

Actual Behavior

  • diagnostics is enabled but not linked to the right AI logger

Steps to Reproduce

  • create an azurerm_api_management_logger/applicationinsights and an azurerm_api_management_diagnostic/applicationinsights resource

  • azurerm_api_management_logger is created and also azurerm_api_management_diagnostic is created and enabled, but there is no resource created under /diagnostics/applicationinsights/loggers/logger-name, which would link both

References

  • This is achieved by implementing the diagnosticlogger client, which is missing in the tf-azurerm resources.
@katbyte katbyte added this to the v2.10.0 milestone May 14, 2020
katbyte pushed a commit that referenced this issue May 14, 2020
…management_logger_id` (#6682)

fix #6619

This will be a breaking change for it adds a required field "logger_id"

=== RUN TestAccAzureRMApiManagementDiagnostic_basic
=== PAUSE TestAccAzureRMApiManagementDiagnostic_basic
=== CONT TestAccAzureRMApiManagementDiagnostic_basic
--- PASS: TestAccAzureRMApiManagementDiagnostic_basic (2498.17s)
=== RUN TestAccAzureRMApiManagementDiagnostic_update
=== PAUSE TestAccAzureRMApiManagementDiagnostic_update
=== CONT TestAccAzureRMApiManagementDiagnostic_update
--- PASS: TestAccAzureRMApiManagementDiagnostic_update (2566.13s)
=== RUN TestAccAzureRMApiManagementDiagnostic_requiresImport
=== PAUSE TestAccAzureRMApiManagementDiagnostic_requiresImport
=== CONT TestAccAzureRMApiManagementDiagnostic_requiresImport
--- PASS: TestAccAzureRMApiManagementDiagnostic_requiresImport (2330.79s)
PASS

(also fixes #6104)
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jun 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants