Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WAF Policy Managed Rule definitions #5727

Closed
rdbartram opened this issue Feb 13, 2020 · 3 comments · Fixed by #6126
Closed

Support for WAF Policy Managed Rule definitions #5727

rdbartram opened this issue Feb 13, 2020 · 3 comments · Fixed by #6126

Comments

@rdbartram
Copy link
Contributor

rdbartram commented Feb 13, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In when configuring the WAF policy. In addition to defining custom rules I want to be able to defined which predefined/managed rules are active on the policy. This is supported by ARM right now and I assume az cli too.

New or Affected Resource(s)

  • azurerm_web_application_firewall_policy

Potential Terraform Configuration

resource "azurerm_web_application_firewall_policy" "example" {
  name                = "example-wafpolicy"
  resource_group_name = azurerm_resource_group.example.name
  location            = azurerm_resource_group.example.location

  managedRuleSet {
    ruleSetType    = "OWASP"
    ruleSetVersion = "3.1"
    
    ruleGroupOverride {
      ruleGroupName = "REQUEST-920-PROTOCOL-ENFORCEMENT"
      disabledRules = [
        "920300",
        "920440"
      ]
    }

    ruleGroupOverride {
      ruleGroupName = "REQUEST-942-APPLICATION-ATTACK-SQLI"
      disabledRules = [
        "942440"
      ]
    }
  }
}

References

@sirlatrom
Copy link
Contributor

I have a pull request coming for this. I'll try to accommodate the suggested Terraform config.

sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Mar 16, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Mar 21, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Mar 25, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Mar 26, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Mar 30, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Apr 20, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Apr 20, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Apr 20, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Apr 20, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Apr 20, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Apr 25, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
sirlatrom added a commit to sirlatrom/terraform-provider-azurerm that referenced this issue Apr 25, 2020
Also streamline singular plurality for optional blocks allowing
multiple repetitions.

Fixes hashicorp#5727.

Signed-off-by: Sune Keller <[email protected]>
@katbyte katbyte added this to the v2.8.0 milestone Apr 26, 2020
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.8.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.8.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented May 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants