r/kubernetes_cluster: allowing the Service Principal to be updated #4469

tombuildsstuff · 2019-10-01T06:27:46Z

This PR fixes both #4356 and #3375 by allowing the Service Principal to be updated - and also attempts to retrieve it from the state using either a Set (prior to 1.34) or a List (after 1.34)

In addition to ensure the state is consistent for nested fields this PR also updates the flatten functions to ensure that all fields within nested blocks are set

Fixes #4356
Fixes #3375

…NetworkingKubenet

…Network

katbyte

LGTM 👍

tombuildsstuff · 2019-10-01T10:46:20Z

Ignoring a couple of temporary AKS capacity tests (which passed on a retry) the tests pass:

tombuildsstuff · 2019-10-01T11:04:40Z

Seems fine in state migrations from 1.33.1 -> this branch & 1.33.1 -> 1.34.0 -> this branch

ghost · 2019-10-04T10:37:24Z

This has been released in version 1.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.35.0"
}
# ... other configuration ...

Bowbaq · 2019-10-04T22:38:57Z

@tombuildsstuff this breaks for me locally. Running terraform apply, I get:

Error: rpc error: code = Unavailable desc = transport is closing

Running with TF_LOG=debug I get:

Error: rpc error: code = Unavailable desc = transport is closing



Error: rpc error: code = Unavailable desc = transport is closing


Releasing state lock. This may take a few moments...
panic: interface conversion: interface {} is nil, not map[string]interface {}
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: 
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: goroutine 265 [running]:
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: github.com/terraform-providers/terraform-provider-azurerm/azurerm.flattenAzureRmKubernetesClusterServicePrincipalProfile(0xc00097d550, 0xc000016460, 0x19, 0x3e7ece0, 0xc0009f1020)
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_kubernetes_cluster.go:1593 +0x370
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: github.com/terraform-providers/terraform-provider-azurerm/azurerm.resourceArmKubernetesClusterRead(0xc000016460, 0x3e18720, 0xc00077a480, 0xc000016460, 0x0)
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-azurerm/azurerm/resource_arm_kubernetes_cluster.go:902 +0x163c
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/schema.(*Resource).RefreshWithoutUpgrade(0xc0005d9500, 0xc0005ae230, 0x3e18720, 0xc00077a480, 0xc000795b00, 0xc0005ae230, 0x0)
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/schema/resource.go:455 +0x119
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/plugin.(*GRPCProviderServer).ReadResource(0xc0000cc038, 0x4b95d80, 0xc000610000, 0xc0005ae140, 0xc0000cc038, 0xc000610000, 0xc001225ba8)
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/helper/plugin/grpc_provider.go:525 +0x3d7
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/internal/tfplugin5._Provider_ReadResource_Handler(0x42c4620, 0xc0000cc038, 0x4b95d80, 0xc000610000, 0xc0005ae0a0, 0x0, 0x4b95d80, 0xc000610000, 0xc000b3a000, 0x539a)
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/github.com/hashicorp/terraform/internal/tfplugin5/tfplugin5.pb.go:3181 +0x23e
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: github.com/terraform-providers/terraform-provider-azurerm/vendor/google.golang.org/grpc.(*Server).processUnaryRPC(0xc000547500, 0x4be3780, 0xc000547800, 0xc00132c000, 0xc0006e4d20, 0x820f510, 0x0, 0x0, 0x0)
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/google.golang.org/grpc/server.go:972 +0x470
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: github.com/terraform-providers/terraform-provider-azurerm/vendor/google.golang.org/grpc.(*Server).handleStream(0xc000547500, 0x4be3780, 0xc000547800, 0xc00132c000, 0x0)
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/google.golang.org/grpc/server.go:1252 +0xda6
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: github.com/terraform-providers/terraform-provider-azurerm/vendor/google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc0005e2020, 0xc000547500, 0x4be3780, 0xc000547800, 0xc00132c000)
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/google.golang.org/grpc/server.go:691 +0x9f
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: created by github.com/terraform-providers/terraform-provider-azurerm/vendor/google.golang.org/grpc.(*Server).serveStreams.func1
2019-10-04T15:29:20.023-0700 [DEBUG] plugin.terraform-provider-azurerm_v1.35.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-azurerm/vendor/google.golang.org/grpc/server.go:689 +0xa1

Applying using 1.34 seems to work fine. Our service principal config looks like this:

  service_principal {
    client_id     = module.k8s-principal.client_id
    client_secret = module.k8s-principal.client_secret
  }

We're using terraform 0.12

tbsquare01 · 2019-11-28T23:32:39Z

@tombuildsstuff is the fix for #4356 expected in "~> 1.35.0" Azure provider?
AKS cluster is still destroying in "1.35.0", the plugin I am using for my deployment.

2019-11-28T23:08:02.1134262Z
2019-11-28T23:08:02.1134390Z �[0m�[1mInitializing the backend...�[0m
2019-11-28T23:08:02.1134505Z �[0m�[32m
2019-11-28T23:08:02.1134657Z Successfully configured the backend "azurerm"! Terraform will automatically
2019-11-28T23:08:02.1134837Z use this backend unless the backend configuration changes.�[0m
2019-11-28T23:08:02.1134931Z
2019-11-28T23:08:02.1135064Z �[0m�[1mInitializing provider plugins...�[0m
2019-11-28T23:08:02.1135226Z - Checking for available provider plugins...
2019-11-28T23:08:02.3278343Z - Downloading plugin for provider "random" (hashicorp/random) 2.2.1...
2019-11-28T23:08:03.0505287Z - Downloading plugin for provider "azurerm" (hashicorp/azurerm) 1.37.0...
2019-11-28T23:08:05.1823490Z

�[0m�[1mrandom_string.id_string: Refreshing state... [id=b0dyrs]�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Refreshing state... [id=/subscriptions/.../resourcegroups/myRG/providers/Microsoft.ContainerService/managedClusters/K8SAKS]�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Destroying... [id=/subscriptions/-.../resourcegroups/myRG/providers/Microsoft.ContainerService/managedClusters/K8SAKS]�[0m�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Still destroying... [id=/subscriptions/-...erService/managedClusters/K8SAKS, 10s elapsed]�[0m�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Still destroying... [id=/subscriptions/-...erService/managedClusters/K8SAKS, 20s elapsed]�[0m�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Still destroying... [id=/subscriptions/-...erService/managedClusters/K8SAKS, 30s elapsed]�[0m�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Still destroying... [id=/subscriptions/-...erService/managedClusters/K8SAKS, 50s elapsed]�[0m�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Still destroying... [id=/subscriptions/-...erService/managedClusters/K8SAKS, 1m0s elapsed]�[0m�[0m
[...]
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Destruction complete after 11m5s�[0m�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Creating...�[0m�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Still creating... [10s elapsed]�[0m�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Still creating... [21s elapsed]�[0m�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Still creating... [31s elapsed]�[0m�[0m
�[0m�[1mazurerm_kubernetes_cluster.aks_cluster: Still creating... [41s elapsed]�[0m�[0m

tombuildsstuff · 2019-11-29T06:29:13Z

@tbsquare01 the AKS API has undergone a bunch of changes of late - as such at this time I'd recommend using version 1.37 of the Azure Provider instead

ghost · 2019-11-29T14:50:14Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

tombuildsstuff added 3 commits September 30, 2019 20:25

r/kubernetes_cluster: adding a separate update method

c30c399

r/kubernetes_cluster: conditionally updating the sp

6900557

r/kubernetes_cluster: ensuring all fields are set

dc5d00a

tombuildsstuff added enhancement service/kubernetes-cluster labels Oct 1, 2019

tombuildsstuff added this to the v1.35.0 milestone Oct 1, 2019

ghost added size/XL documentation labels Oct 1, 2019

tombuildsstuff added 7 commits October 1, 2019 08:30

r/kubernetes_cluster: fixing TestAccAzureRMKubernetesCluster_advanced…

5c0bd22

…NetworkingKubenet

r/kubernetes_cluster: using constant versions of kubernetes

3552282

r/kubernetes_cluster: fixing TestAccAzureRMKubernetesCluster_internal…

4f1d973

…Network

r/kubernetes_cluster: setting the correct field

b8e516e

r/kubernetes_cluster: adding an ignore_changes until 2.0

2abc24b

linting

c870d6b

r/kubernetes_cluster: fixing the log messages

2649727

tombuildsstuff requested a review from katbyte October 1, 2019 08:15

katbyte approved these changes Oct 1, 2019

View reviewed changes

r/kubernetes_cluster: fixing the casing for the sku

838eca9

tombuildsstuff changed the title ~~[WIP] r/kubernetes_cluster: allowing the Service Principal to be updated~~ r/kubernetes_cluster: allowing the Service Principal to be updated Oct 1, 2019

tombuildsstuff merged commit 5b71408 into master Oct 1, 2019

tombuildsstuff deleted the b/aks-service-principal branch October 1, 2019 11:04

tombuildsstuff added a commit that referenced this pull request Oct 1, 2019

updating to include #4469

dafdc6d

tombuildsstuff mentioned this pull request Oct 1, 2019

aks forces to destroy #4356

Closed

tshafeev mentioned this pull request Oct 8, 2019

1.35 version crash, AKS SP problem #4519

Closed

tombuildsstuff mentioned this pull request Nov 5, 2019

azurerm_kubernetes_cluster - update service principal creates new cluster #4069

Closed

ghost locked and limited conversation to collaborators Nov 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/kubernetes_cluster: allowing the Service Principal to be updated #4469

r/kubernetes_cluster: allowing the Service Principal to be updated #4469

tombuildsstuff commented Oct 1, 2019 •

edited

Loading

katbyte left a comment

tombuildsstuff commented Oct 1, 2019

tombuildsstuff commented Oct 1, 2019

ghost commented Oct 4, 2019

Bowbaq commented Oct 4, 2019

tbsquare01 commented Nov 28, 2019

tombuildsstuff commented Nov 29, 2019

ghost commented Nov 29, 2019

r/kubernetes_cluster: allowing the Service Principal to be updated #4469

r/kubernetes_cluster: allowing the Service Principal to be updated #4469

Conversation

tombuildsstuff commented Oct 1, 2019 • edited Loading

katbyte left a comment

Choose a reason for hiding this comment

tombuildsstuff commented Oct 1, 2019

tombuildsstuff commented Oct 1, 2019

ghost commented Oct 4, 2019

Bowbaq commented Oct 4, 2019

tbsquare01 commented Nov 28, 2019

tombuildsstuff commented Nov 29, 2019

ghost commented Nov 29, 2019

tombuildsstuff commented Oct 1, 2019 •

edited

Loading