Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster - update service principal creates new cluster #4069

Closed
AlexBevan opened this issue Aug 13, 2019 · 2 comments
Closed

Comments

@AlexBevan
Copy link

AlexBevan commented Aug 13, 2019

  name                = var.prefix
  location            = azurerm_resource_group.main.location
  resource_group_name = azurerm_resource_group.main.name
  dns_prefix          = var.prefix
  kubernetes_version = "1.12.8"

  agent_pool_profile {
    name            = "default"
    count           = var.numberOfAgents
    vm_size         = var.sizeOfAgents
    os_type         = "Linux"
    os_disk_size_gb = 30
    vnet_subnet_id  = var.subnet_id
    max_pods        = var.max_pods
  }

  linux_profile {
    admin_username = var.admin_username

    ssh_key {
      key_data = file(var.ssh_key)
    }
  }

  network_profile {
    network_plugin     = "azure"
    dns_service_ip     = "172.18.0.10"
    docker_bridge_cidr = "172.17.0.1/16"
    service_cidr       = "172.18.0.0/24"
  }

  service_principal {
    client_id     = azurerm_azuread_application.aks_app.application_id
    client_secret = random_string.aks_sp_password.result
  }

  tags = "${var.tags}"

}

Expected Behavior

Updating service_principal id should not recreate the cluster

Actual Behavior

Updating service_principal id recreates the cluster

Non-descructive when done via CLI az aks update-credentials

@tombuildsstuff
Copy link
Contributor

hi @AlexBevan

Just to let you know that support for this shipped in v1.35.0 (via #4469) - you can upgrade to this by updating the version in the Provider block (as shown below) and then running terraform init -upgrade:

provider "azurerm" {
  version = "=1.35.0"
}

Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants